Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper modifiers support #59

Closed
ameshkov opened this issue Aug 8, 2017 · 5 comments
Closed

Add helper modifiers support #59

ameshkov opened this issue Aug 8, 2017 · 5 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Aug 8, 2017

  • first-party -- This is the very same as ~third-party

  • xhr -- this is the very same as xmlhttprequest

  • popunder -- the same as popup (needs investigation)

  • 1p

  • 3p

  • all

  • css

  • frame

@hmage
Copy link

hmage commented Aug 8, 2017

Already done.

filtering/urlfilter/src/urlfilter.cc:956

@ameshkov
Copy link
Member Author

ameshkov commented Aug 8, 2017

Hmm, what about tests? Do we need it to add tests to the android library code?

@hmage
Copy link

hmage commented Aug 8, 2017

Yeah, having tests is nice idea, right now there's no test that covers this -- it should be relatively simple to add -- just see if first-party is accepted and if rule matches the way it should.

@ameshkov ameshkov assigned ameshkov and unassigned hmage Aug 8, 2017
@ameshkov
Copy link
Member Author

ameshkov commented Aug 8, 2017

Re-assigned to myself then

@ameshkov ameshkov modified the milestones: FE v1.1, Next release Jun 7, 2018
@ameshkov ameshkov modified the milestones: Postponed enhancements, v1.4 May 26, 2019
@ameshkov ameshkov changed the title Add first-party modifier support Add helper modifier support May 26, 2019
@ameshkov ameshkov changed the title Add helper modifier support Add helper modifiers support May 26, 2019
@ameshkov ameshkov modified the milestones: v1.4, v1.5 May 30, 2019
@ameshkov ameshkov assigned sxgunchenko and unassigned ameshkov Jul 30, 2019
@sxgunchenko
Copy link

core/pull-requests/1437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants