Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List-KR #151

Closed
ghost opened this issue Jan 4, 2019 · 7 comments
Closed

Add List-KR #151

ghost opened this issue Jan 4, 2019 · 7 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jan 4, 2019

List-KR is a web filter for websites in Korean language. This filter aims to filter not only ads, but also known trackers and other scripts which negatively affects user experience. SlowMemory, a original contributor, has deleted all his projects suddenly. As a result, Old List-KR filter have obsoleted in AdGuard configuration UI. So i have recreated this project repository for continued development.

Would you please add this list so it is available in the AdGuard configuration UI and can be enabled by users via a checkbox in the usual filter selection settings screen, and remove '(Obsolete) List-KR' filter?

@Alex-302
Copy link
Member

Alex-302 commented Jan 4, 2019

It is not original filter: so i have recreated this project repository for continued development.
Please watch it some time.

@ameshkov
Copy link
Member

ameshkov commented Jan 4, 2019

@ptrkr thank you for the contribution!

I'll set a reminder and will check it in 14 days to see if this subscription is actively developed.

@ameshkov
Copy link
Member

@ptrkr I remember:) I'll get back to it on Monday

@ghost
Copy link
Author

ghost commented Jan 22, 2019

@ameshkov Sorry for duplicate mention, but.. is anyone there?

@ameshkov
Copy link
Member

Yep, all good. @Alex-302 let's replace the obsolete List-KR then.

@ameshkov
Copy link
Member

@ptrkr there's one issue, though. The original List-KR used JS and $replace rules which we do not generally allow to third-party filters (we made a one-time exception for SlowMemory).

Please wait till we add scriptlets support: AdguardTeam/CoreLibs#664

Meanwhile, if these rules are strictly necessary, please pull-request them directly to https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/ThirdParty/filter_227_List-KR/template.txt

@Alex-302
Copy link
Member

#155

Alex-302 added a commit that referenced this issue Jan 22, 2019
@ghost ghost mentioned this issue Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants