-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix escaped commas in uBO scriptlet parameters #95
Comments
@scripthunter7 @slavaleleka On my end this doesn't seem to be fixed despite a month has passed since closing this issue. Still escaped commas are shown in red: https://github.com/uBlockOrigin/uAssets/blob/a7d6966930f7648d9cc5740f5b03fb05f86029d4/filters/annoyances-cookies.txt#L63 Also, now as uBO has started to support using quotes in values https://github.com/uBlockOrigin/uAssets/blob/562d4c6043f38ec3786dc34119d26e711140d6cf/filters/annoyances-cookies.txt#L124 I see that the quoted value still has commas colored in red. However, there seems to be no issues in quoted AG values for some reason https://github.com/AdguardTeam/AdguardFilters/blob/2c9040591d31c180b99e2a599e7150a7b5c7a2a5/AnnoyancesFilter/Cookies/sections/cookies_specific.txt#L232 |
GitHub highlighter takes time to update, you can learn more at https://github.com/AdguardTeam/VscodeAdblockSyntax#reporting-issues
At first glance, this appears to be a new issue that needs to be fixed, since this feature is not yet supported by the highlighter.
Yes, because the two types of scriptlet parameter management are a little different. |
Oh okay. Thanks for the info. |
Escaped commas are highlighted incorrectly.
Example rule:
from https://github.com/uBlockOrigin/uAssets/blob/a7d6966930f7648d9cc5740f5b03fb05f86029d4/filters/annoyances-cookies.txt#L63
Show screenshot
Reported by @peace2000
The text was updated successfully, but these errors were encountered: