Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitTimeSeconds being set to default even if developer called it with 0 #240

Open
Ayman-Sage opened this issue Sep 2, 2021 · 1 comment
Assignees

Comments

@Ayman-Sage
Copy link

Ayman-Sage commented Sep 2, 2021

we just came across this issue when trying to set waitTimeSeconds to 0 which means don't do "long polling" and just look now without waiting.. but in the code it is always being set to default if it was passed as 0... is this intentional?

https://github.com/p4tin/goaws/blob/ba73e9b3195a592346488cab2dcaf61807605184/app/gosqs/gosqs.go#L412

@chrisdaly3 chrisdaly3 self-assigned this Mar 4, 2023
@Admiral-Piett
Copy link
Owner

@Ayman-Sage Hm - I need to dig a little deeper on this, but I think that's probably just a relic of initializing that variable with 0 and assuming that means it wasn't overwritten. I'll think about this - since I think you're right, you should have the ability to "receive it NOW".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants