add support for TSA Certificates #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int numSignableEntriesInJar = 0; | ||
|
|
||
| // Record current time just before checking the jar begins. | ||
| final ZonedDateTime now = ZonedDateTime.now(); | ||
| final ZonedDateTime shortlyAfterNow = now.plus(6, MONTHS); |
There was a problem hiding this comment.
6 month are not "shortly after now" ;)
| final X509Certificate tsaCertificate = (X509Certificate) optionalSignatureTimestamp | ||
| .map(Timestamp::getSignerCertPath) | ||
| .map(CertPath::getCertificates) | ||
| .map(certs -> certs.get(0)) |
There was a problem hiding this comment.
can this end in an ArrayOutOfBounds? Maybe a filter before that one makes sense.
| if (tsaCertificate != null) { | ||
| final ZonedDateTime tsaNotBefore = zonedDateTime(tsaCertificate.getNotBefore()); | ||
| final ZonedDateTime tsaNotAfter = zonedDateTime(tsaCertificate.getNotAfter()); | ||
| final ZonedDateTime signedAt = zonedDateTime(optionalSignatureTimestamp.get().getTimestamp()); |
There was a problem hiding this comment.
We should use orElseThrow instead of get here. I understand that I can not happen now that the val is null but maybe in future based on refactoring. So maybe throw a specific exception + description here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.