Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

update jdk10 link #127

Merged
merged 3 commits into from
Jul 12, 2019
Merged

update jdk10 link #127

merged 3 commits into from
Jul 12, 2019

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 10, 2019

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

fixes: #126

@gdams gdams requested a review from karianna July 10, 2019 15:04
@@ -3,7 +3,7 @@
sha256 '550fac840563073dcfaa1ffd4a3a9cc68fd8ccc71bbc65baf3cb32ec734c30dd'

# github.com/AdoptOpenJDK was verified as official when first introduced to the cask
url "https://github.com/AdoptOpenJDK/openjdk#{version.before_comma}-binaries/releases/download/jdk-#{version.before_comma}.#{version.after_comma.before_colon}%2B#{version.after_colon}/OpenJDK#{version.before_comma}U-jdk_x64_mac_hotspot_#{version.before_comma}.#{version.after_comma.before_colon}_#{version.after_colon}.tar.gz"
url 'https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk-10.0.2%2B13.1/OpenJDK10U-jdk_x64_mac_hotspot_10.0.2_13.tar.gz'
Copy link

@swapnilsatpute swapnilsatpute Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdams
It's sufficient to change version '10,0.2:13' to version '10,0.2:13.1'

Copy link

@swapnilsatpute swapnilsatpute Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right URL for binary is
https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk-10.0.2%2B13.1/OpenJDK10U-jdk_x64_mac_hotspot_10.0.2_13.tar.gz

diff --git a/Casks/adoptopenjdk10.rb b/Casks/adoptopenjdk10.rb
index 08ff497..68979f8 100644
--- a/Casks/adoptopenjdk10.rb
+++ b/Casks/adoptopenjdk10.rb
@@ -1,9 +1,9 @@
 cask 'adoptopenjdk10' do
-  version '10,0.2:13'
+  version '10,0.2:13.1'
   sha256 '550fac840563073dcfaa1ffd4a3a9cc68fd8ccc71bbc65baf3cb32ec734c30dd'
 
   # github.com/AdoptOpenJDK was verified as official when first introduced to the cask
-  url "https://github.com/AdoptOpenJDK/openjdk#{version.before_comma}-binaries/releases/download/jdk-#{version.before_comma}.#{version.after_comma.before_colon}%2B#{version.after_colon}/OpenJDK#{version.before_comma}U-jdk_x64_mac_hotspot_#{version.before_comma}.#{version.after_comma.before_colon}_#{version.after_colon}.tar.gz"
+  url "https://github.com/AdoptOpenJDK/openjdk#{version.before_comma}-binaries/releases/download/jdk-#{version.before_comma}.#{version.after_comma.before_colon}%2B#{version.after_colon}/OpenJDK#{version.before_comma}U-jdk_x64_mac_hotspot_#{version.before_comma}.#{version.after_comma.before_colon}_#{version.after_colon.major}.tar.gz"
   appcast "https://github.com/adoptopenjdk/openjdk#{version.before_comma}-binaries/releases.atom"
   name 'AdoptOpenJDK 10'
   homepage 'https://adoptopenjdk.net/'

something like this might be good as a temporary fix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified

$ brew cask audit --download Casks/adoptopenjdk10.rb
==> Downloading https://github.com/AdoptOpenJDK/openjdk10-binaries/releases/download/jdk-10.0.2%2B13.1/OpenJDK10U-jdk_x64_mac_hotspot_10.0.2_13.tar.gz
==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/140418978/8b643480-f247-11e8-8bee-38e0f2e5dfd1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2
########                                                                  11.9%

@karianna karianna added this to the July 2019 milestone Jul 12, 2019
@karianna karianna added the bug Something isn't working label Jul 12, 2019
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 6c4fe29 into master Jul 12, 2019
@gdams gdams deleted the jdk10 branch November 1, 2019 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not install openjdk10
3 participants