Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Adds adoptopenjdk11-open9-jre for #24 #82

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Adds adoptopenjdk11-open9-jre for #24 #82

merged 1 commit into from
Mar 17, 2019

Conversation

Okeanos
Copy link
Contributor

@Okeanos Okeanos commented Mar 16, 2019

This should add adoptopenjdk11-open9-jre according to #24.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask in a similar way to the existing casks.
  • Added new cask to the README.md
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.

@karianna karianna added the enhancement New feature or request label Mar 17, 2019
@karianna karianna requested a review from gdams March 17, 2019 10:45
@gdams gdams merged commit 9da7688 into AdoptOpenJDK:master Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Okeanos @gdams @karianna