This repository has been archived by the owner on Oct 14, 2021. It is now read-only.
possible semver incompatibility fix #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## staging #311 +/- ##
=============================================
- Coverage 69.82% 69.34% -0.48%
Complexity 280 280
=============================================
Files 100 101 +1
Lines 2525 2574 +49
Branches 307 313 +6
=============================================
+ Hits 1763 1785 +22
- Misses 582 607 +25
- Partials 180 182 +2
Continue to review full report at Codecov.
|
karianna
approved these changes
Nov 13, 2020
| .sortedBy { ghAssetWithMetadata -> ghAssetWithMetadata.value.version.toApiVersion() } | ||
| .last().value.version.toApiVersion() | ||
|
|
||
| version = if (version.semver != version.formSemver()) { |
There was a problem hiding this comment.
We should extract into its own function since its a special case
There was a problem hiding this comment.
Do we have a test for this special case?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mvn clean installbuild and test completes