-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only try and archive Mac & Win buildInstaller artifacts #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrew-m-leonard <andrew_m_leonard@uk.ibm.com>
Test builds look good |
sxa
requested changes
May 28, 2020
M-Davies
requested changes
May 28, 2020
Signed-off-by: andrew-m-leonard <andrew_m_leonard@uk.ibm.com>
karianna
added
the
enhancement
Issues that enhance the code or documentation of the repo in any way
label
May 28, 2020
M-Davies
approved these changes
May 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref conversation in Slack https://adoptopenjdk.slack.com/archives/C09NW3L2J/p1590677164357100
xLinux JDK15 running cleanly after these changes so i'm hopeful that things will look better tomorrow than they have for the last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: andrew-m-leonard andrew_m_leonard@uk.ibm.com