Update the HMAC Key field to be empty instead of null (#924)

Adyen · Jun 26, 2023 · e432186 · e432186
1 parent 53a566d
commit e432186
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...dges/bm_adyen/cartridge/templates/default/adyenSettings/settingCards/webhookSettings.isml b/...dges/bm_adyen/cartridge/templates/default/adyenSettings/settingCards/webhookSettings.isml
@@ -43,7 +43,7 @@
             <div class="input-fields">
                <input type="password" class="form-control" name="Adyen_Hmac_Key" id="hmacKey"
                   aria-describedby="hmacKeyHelp" placeholder=""
-                  value="${AdyenConfigs.getAdyenHmacKey()}">
+                  value="${AdyenConfigs.getAdyenHmacKey() || ''}">
             </div>
          </div>
       </div>

diff --git a/src/cartridges/int_adyen_SFRA/cartridge/controllers/middlewares/adyen/notify.js b/src/cartridges/int_adyen_SFRA/cartridge/controllers/middlewares/adyen/notify.js
@@ -8,10 +8,10 @@ const AdyenConfigs = require('*/cartridge/scripts/util/adyenConfigs');
  */
 
 function handleHmacVerification(hmacKey, req) {
-  if (!hmacKey) {
-    return false;
+  if (hmacKey) {
+    return checkAuth.validateHmacSignature(req);
   }
-  return checkAuth.validateHmacSignature(req);
+  return true;
 }
 
 function notify(req, res, next) {