Update the HMAC Key field to be empty instead of null #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenit2001
requested review from
maassenbas,
zaiddreakh,
amihajlovski and
shanikantsingh
as code owners
zenit2001
changed the title
amihajlovski
approved these changes
Jun 26, 2023
shanikantsingh
approved these changes
Jun 26, 2023
maassenbas
reviewed
Jun 29, 2023
| } | ||
| return checkAuth.validateHmacSignature(req); | ||
| return true; |
There was a problem hiding this comment.
How are we handling cases without HMAC validation?
Should we add a log to make a merchant aware that they are not using HMAC and that we are recommending using that?
There was a problem hiding this comment.
For cases where the HMAC key is not setup in the BM, the HMAC validation will not be triggered. If we add a log for recommending the usage of HMAC validation, every time a payment is made and merchant doesn't use HMAC validation, a log will be added in the log file, which may not be the best approach to follow.
Instead, I think it will be better to recommend the usage of HMAC validation in the documentation.
amihajlovski
pushed a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the HMAC Key field in BM to empty instead of null if no input is provided and updates the hmacVerification to not be false in case no hmac key is setup