Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all adyen util files to the same folder #1061

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Having a structured a structured cartridge.
  • What existing problem does this pull request solve?
    Moving all adyen related util and helper files to the same folder. Removed some index files which were not required and not inline with the structure we are following.

Tested scenarios

Description of tested scenarios:

  • Card Payments
  • Redirect Payments (iDeal, PayPal)
  • Giftcards
  • Webhook processing

Fixed issue: SFI-684

@zenit2001 zenit2001 marked this pull request as ready for review April 2, 2024 11:01
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 merged commit 06f9090 into feature/SFI-544-separate-cartridges Apr 4, 2024
15 checks passed
@zenit2001 zenit2001 deleted the improvement/SFI-684-restructure_util_files branch April 4, 2024 11:43
@zenit2001 zenit2001 added the refactor Refactors existing code label Apr 5, 2024
zenit2001 added a commit that referenced this pull request Apr 23, 2024
* Move BE code to int_adyen_SFRA (#1056)

* move frontend code to app_adyen_SFRA (#1057)

* Get checkout payment methods adjustment (#1046)

* Replaced /sessions with /paymentMethods for apple pay express (#1047)

* Replaced /sessions with /paymentMethods from end of checkout (#1049)

* Remove sessions call from My Account (#1050)

* chore: removed /sessions related code from the cartridge (#1051)

* chore: removed services for sessions (#1053)

* chore: disabled linter temporarily

* chore: updated eslint ignore

* chore: move frontend code to app_adyen_SFRA

* chore: fix eslint issues

---------

Co-authored-by: Zenit Shkreli <69572953+zenit2001@users.noreply.github.com>

* Restructure folders for logging and webhooks (#1059)

* chore: added lint to some files in int_adyen_SFRA (#1060)

* Moved all adyen util files to the same folder (#1061)

* Passing amount to giftcard component on creation (#1066)

* Moved adyen scripts under the same directory and groupped them based on functionality (#1064)

* GitHub pipeline adjustement (#1065)

* Merging changes of develop into SFI-544 (#1068)

* chore: added paypal line items feature

* chore: added tests for paypal line items

---------

Co-authored-by: Shani <31096696+shanikantsingh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants