Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring the cartridges structure #1071

Merged
merged 13 commits into from
Apr 23, 2024

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    This PR separates the front-end logic from the back-end logic.
    The front-end related files now live in app_adyen_SFRA , while back-end files live in int_adyen_SFRA.
    int_adyen_overlay is not anymore part of our cartridge.
    Inside int_adyen_SFRA, some files have been re-groupped depending on their functionalities.
  • What existing problem does this pull request solve?
    It restructures the folder and file structure, enabling easier navigation through the files and ease in customization.

Tested scenarios

Description of tested scenarios:

Fixed issue: SFI-544

zenit2001 and others added 10 commits February 29, 2024 13:39
* Get checkout payment methods adjustment (#1046)

* Replaced /sessions with /paymentMethods for apple pay express (#1047)

* Replaced /sessions with /paymentMethods from end of checkout (#1049)

* Remove sessions call from My Account (#1050)

* chore: removed /sessions related code from the cartridge (#1051)

* chore: removed services for sessions (#1053)

* chore: disabled linter temporarily

* chore: updated eslint ignore

* chore: move frontend code to app_adyen_SFRA

* chore: fix eslint issues

---------

Co-authored-by: Zenit Shkreli <69572953+zenit2001@users.noreply.github.com>
@zenit2001 zenit2001 added the refactor Refactors existing code label Apr 19, 2024
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@zenit2001 zenit2001 marked this pull request as ready for review April 22, 2024 14:23
@zenit2001 zenit2001 merged commit 7aecd37 into develop Apr 23, 2024
14 of 15 checks passed
@zenit2001 zenit2001 added breaking-change A Breaking Change and removed refactor Refactors existing code labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants