🎨 Code clean-up #139
Merged
🎨 Code clean-up #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
❌ Deploy Preview for adyen-lume failed.
|
joao-m-santos
force-pushed
the
130-code-clean-up
branch
from
abc646d
to
727f4da
Compare
joao-m-santos
force-pushed
the
130-code-clean-up
branch
from
f87b7d9
to
91eb6a2
Compare
6 tasks
* Removed unused computed prop * Improved imports * Use group props instead of chart props
* Also some minor code improvements
* Renamed the alluvial group composables * Simplified composable code and their responsibilities * Moved alluvialInstance properties to be options (better aligned with other charts work) * Added new AlluvialDiagramOptions type * Simplified alluvial specific typings * Added new errors composable to log chart errors * Improved alluvial diagram performance * Decreased re-render count * Decreased overall function calls
joao-m-santos
force-pushed
the
130-code-clean-up
branch
from
96ddc0b
to
982a647
Compare
vivy27
reviewed
Jan 31, 2023
vivy27
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #130
📝 Description
1643ad0 ✅ Fix test failure (wrong import)
982a647 🎨 Update prop composables & docs data
bc47d57 ✅ Fix unit tests
1afa447 ♻️ Abstract lume-alluvial-path-group to lume-alluvial-group
b8f810a ♻️ Refactor Alluvial diagram and its sub-elements
c0463c4 🎨 Remove duplicate DEFAULT_COLOR variable
b214a09 ✅ Add group-props spec test file
2b8d40e 🚚 Move group-props to @/composables
fc656db ✅ Fix failing test
ea601ef 🚚 Move path-group into alluvial-group folder
8083216 🩹 Fix chart legend stories
dfb5f00 ♻️ Refactor lume-point API; Add stories; Update docs
a4089b1 ♻️ Refactor group components into script setup
8468a02 🎨 Remove Vue.set; Improve chartType; Add title color vars
0064b59 📝 Add lume-line stories; Update documentation
6cad45f ♻️ Move transition logic to line-group
85bdbb2 🎨 Remove Vue import and Vue.set usage
55bf875 💄 Remove color from alluvial end node
💥 Is this a breaking change (Yes/No):
📝 Additional Information
Before submitting the PR, please make sure you do the following
fixes #123).