♻️ Alluvial diagram refactor #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for adyen-lume ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Dependant on #139 |
joao-m-santos
force-pushed
the
130-alluvial-refactor
branch
from
22f6dd1
to
2de3e43
Compare
vivy27
reviewed
Jan 23, 2023
src/components/charts/lume-alluvial-diagram/lume-alluvial-diagram.stories.ts
Show resolved
Hide resolved
src/components/core/lume-chart-legend/lume-chart-legend.stories.ts
Outdated
Show resolved
Hide resolved
src/components/groups/lume-alluvial-group/lume-alluvial-group.vue
Outdated
Show resolved
Hide resolved
* Renamed the alluvial group composables * Simplified composable code and their responsibilities * Moved alluvialInstance properties to be options (better aligned with other charts work) * Added new AlluvialDiagramOptions type * Simplified alluvial specific typings * Added new errors composable to log chart errors * Improved alluvial diagram performance * Decreased re-render count * Decreased overall function calls
joao-m-santos
force-pushed
the
130-alluvial-refactor
branch
from
2de3e43
to
2586834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #130
📝 Description
💥 Is this a breaking change (Yes/No):
📝 Additional Information
Before submitting the PR, please make sure you do the following
fixes #123).