Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapks installs fine :) (unlike apkm crappy format...) #104

Closed
the4anoni opened this issue Mar 28, 2020 · 20 comments
Closed

xapks installs fine :) (unlike apkm crappy format...) #104

the4anoni opened this issue Mar 28, 2020 · 20 comments

Comments

@the4anoni
Copy link

Hello
App blocks of installing xapk file, but when I changed extension to .zip and enabled ZipFile API xapk was installed without any problem.

I've tested on Youtube 15.12.33 from apkpure.com.

Can app detect xapk file, and then install it as zip with ZipFile automatically enabled?

@Cyberavater
Copy link

Also, add export support with data.obb file as .xapk.

@Aefyr
Copy link
Owner

Aefyr commented Mar 29, 2020

The problem is that .xapk file may contain obb data which SAI wouldn't be able to install and for now I don't want to deal with obb. I can allow selecting .xapk files and just make a warning that obb won't be installed if that's fine with you

@IRGC
Copy link

IRGC commented Mar 29, 2020 via email

@shah-sudeep
Copy link

The problem is that .xapk file may contain obb data which SAI wouldn't be able to install and for now I don't want to deal with obb. I can allow selecting .xapk files and just make a warning that obb won't be installed if that's fine with you

Dealing with .obb format won't be too difficult as all we have to do is cooy the file the the specific folder with the app package id.

@Aefyr
Copy link
Owner

Aefyr commented Mar 29, 2020

With upcoming changes to storage in Android R, it will be neccessary to use SAF for that which is already quite the problem. Plus ZipFile in SAI copies the archive to a temp file prior to installing it, so you'll need like 3*(size of the archive) amount of space to install something which can be a problem with big games

@shah-sudeep
Copy link

With upcoming changes to storage in Android R, it will be neccessary to use SAF for that which is already quite the problem. Plus ZipFile in SAI copies the archive to a temp file prior to installing it, so you'll need like 3*(size of the archive) amount of space to install something which can be a problem with big games

Then informing that .obb file will require manual installation will be the best option. As it will at least make other apps that doesn't contain .obb file , possible to install.

@cmohan0004
Copy link

With upcoming changes to storage in Android R, it will be neccessary to use SAF for that which is already quite the problem. Plus ZipFile in SAI copies the archive to a temp file prior to installing it, so you'll need like 3*(size of the archive) amount of space to install something which can be a problem with big games

sir is it possible to add a feature to export also simple apk not just split apks in different or same folder, i use SAI to batch install apps but i have to use other app to make apk backups.

@Aefyr
Copy link
Owner

Aefyr commented Mar 29, 2020

@cmohan0004 there's filter button on export screen

@cmohan0004
Copy link

@cmohan0004 there's filter button on export screen

thank you so much, thats what i was asking for.

@Cyberavater
Copy link

Well, *.xapk 's best charm is its data.obb integration, if not for data.obb there is no need for *.xapk.

@Aefyr
Copy link
Owner

Aefyr commented Apr 9, 2020

Partial (without obb installation) support for XAPK added in 3.10. Pro mode also supports parsing meta from XAPK to display app name, icon and version

@Aefyr Aefyr closed this as completed Apr 9, 2020
@Cyberavater
Copy link

Not sure what's the point of supporting *.xapk without *.obb.

@Aefyr
Copy link
Owner

Aefyr commented Apr 16, 2020

Not sure what's the point of supporting *.xapk without *.obb.

Not all XAPK files contain obb data, some of them just pack split APKs, maybe some people prefer SAI to APKPure installer, idk

@shah-sudeep
Copy link

Not all XAPK files contain obb data, some of them just pack split APKs, maybe some people prefer SAI to APKPure installer, idk

This is the exact reason I wanted to have support for .xapk format here within SAI, bcoz I would prefer to install those .xapk files from SAI instead of APKPure. And as you said, a lot of those .xapk files only contains the split apks without obb.

@shah-sudeep
Copy link

We can deal with the .obb matter latter on when we can get some way to deal with the temp folder, so that we don't require 3x space to deal with the .obb file if we are about to include support.

@shah-sudeep
Copy link

This may be asking too much but now I am wondering how APKPure has managed to deal with the .xapk files?🤔🤔

Wait, can we not just create the temp file inside the data//android/obb/package.name folder for the .xapk format files and delete all apks files afterward the installation of the app leaving only the obb file there. Doing this won't require 3x storage and would also be faster.

Just a thought bcoz I don't know if it is possible to create temp files here or will it require a vast change in architecture for extracting files.

@Aefyr
Copy link
Owner

Aefyr commented Apr 17, 2020

This may be asking too much but now I am wondering how APKPure has managed to deal with the .xapk files?🤔🤔

They probably just use File IO.

Wait, can we not just create the temp file inside the data//android/obb/package.name folder for the .xapk format files and delete all apks files afterward the installation of the app leaving only the obb file there.

This is kinda smart actually and APK files don't have to be extracted to the same directory. But it will require some additional setup where user grants SAI access to obb directory via SAF. Not sure, how to implement that properly

@Aefyr
Copy link
Owner

Aefyr commented Apr 17, 2020

Wait no, I forgot that the issue with XAPK is that their ZIP format is broken, not that there's no size info. So, it won't work without copying the whole XAPK file to a temp file first.

@shah-sudeep
Copy link

Wait no, I forgot that the issue with XAPK is that their ZIP format is broken, not that there's no size info. So, it won't work without copying the whole XAPK file to a temp file first.

Then can't we make that temp folder the one where .obb file is to be installed??

@Aefyr
Copy link
Owner

Aefyr commented Apr 17, 2020

Then can't we make that temp folder the one where .obb file is to be installed??

No, the whole XAPK has to be copied, not the files from it because it just can't be read via ZipInputStream due to a broken format. So even if you copy the XAPK file to the directory where the obb file should be, you still need to extract that obb file from the XAPK file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants