Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add min and max values to output metadata #55

Open
Ionospheres opened this issue Jul 7, 2021 · 0 comments
Open

[FEAT] Add min and max values to output metadata #55

Ionospheres opened this issue Jul 7, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ionospheres
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It would be nice if the metadata contained the min and max values for any given output variable.

Describe the solution you'd like
I would like the min and max values of the output data to be calculated and included in the respective metadata.

Describe alternatives you've considered
An alternative is to not include the min and max value.

Additional context
Code seed from output_netcdf.cpp, ln 181:

int min = std::min_element(neutrals.species[iSpecies].density_scgc.begin(), neutrals.species[iSpecies].density_scgc.end());
denVar[iSpecies].putAtt(MIN_VAL, std::min_element(neutrals.species[iSpecies].density_scgc.begin(), neutrals.species[iSpecies].density_scgc.end()));
@Ionospheres Ionospheres added the enhancement New feature or request label Jul 7, 2021
@Ionospheres Ionospheres self-assigned this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant