Skip to content

Commit

Permalink
chore(repo): add nx-ignore comment in nrwl/js
Browse files Browse the repository at this point in the history
We call `require('@nrwl/vite')` inside @nrwl/js. This creates a circular dep between vite + js. It was not picked up prior to the new beta, as there was a bug in the typescript import scanner preventing it from being read. See nrwl#13921
  • Loading branch information
AgentEnder committed Jan 4, 2023
1 parent 46b9687 commit 9f9a324
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/js/src/generators/library/library.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export async function projectGenerator(

if (options.bundler === 'vite') {
await ensurePackage(tree, '@nrwl/vite', nxVersion);
// nx-ignore-next-line
const { viteConfigurationGenerator } = require('@nrwl/vite');
const viteTask = await viteConfigurationGenerator(tree, {
project: options.name,
Expand Down Expand Up @@ -99,6 +100,7 @@ export async function projectGenerator(
options.bundler !== 'vite' // Test would have been set up already
) {
await ensurePackage(tree, '@nrwl/vite', nxVersion);
// nx-ignore-next-line
const { vitestGenerator } = require('@nrwl/vite');
const vitestTask = await vitestGenerator(tree, {
project: options.name,
Expand Down

0 comments on commit 9f9a324

Please sign in to comment.