fix(core): find imports in export type statements
#13921
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "analyzeSourceFiles" functionality which automatically detects deps does not currently file "import" requests in statements using the relatively new `export type ... from "..."` syntax. This is happening because the scanner does not find an asterick or curly-bracket after the `export` keyword, so it strips that export statement from the code.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
approved these changes
Dec 30, 2022
AgentEnder
added a commit
to AgentEnder/nx
that referenced
this pull request
Jan 1, 2023
We call `require('@nrwl/vite')` inside @nrwl/js. This creates a circular dep between vite + js. It was not picked up prior to the new beta, as there was a bug in the typescript import scanner preventing it from being read. See nrwl#13921
AgentEnder
added a commit
to AgentEnder/nx
that referenced
this pull request
Jan 4, 2023
We call `require('@nrwl/vite')` inside @nrwl/js. This creates a circular dep between vite + js. It was not picked up prior to the new beta, as there was a bug in the typescript import scanner preventing it from being read. See nrwl#13921
AgentEnder
added a commit
to AgentEnder/nx
that referenced
this pull request
Jan 4, 2023
We call `require('@nrwl/vite')` inside @nrwl/js. This creates a circular dep between vite + js. It was not picked up prior to the new beta, as there was a bug in the typescript import scanner preventing it from being read. See nrwl#13921
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "analyzeSourceFiles" functionality which automatically detects deps does not currently file "import" requests in statements using the relatively new
export type ... from "..."syntax. This is happening because the scanner does not find an asterick or curly-bracket after theexportkeyword, so it strips that export statement from the code.Current Behavior
Today, "import" statements using the relatively new
export type ... from "..."syntax are stripped from the code before analysis occurs. This fixes the scanner to not drop these statements.Expected Behavior
Analysis should identify that a package which includes nothing but
export * from 'some-other-package'has a dependency onsome-other-package, but today no dependency is discovered.Related Issue(s)
I didn't file an issue, if I need to I'd be happy to.