Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned #451

lollypop27 · 2016-11-29T08:32:32Z

Change method name from eleigible_job_seeker_to job_eeker_assigned to job_seekers_assigned_or_assignable_to_ap

houndci-bot · 2016-11-29T08:32:37Z

spec/helpers/agency_people_helper_spec.rb

                          to match_array [adam, bob, dave, charles]

-      expect(eligible_job_seekers_for_role(jd_person, :CM)).
+      expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :CM)).


Place the . on the next line, together with the method name.

houndci-bot · 2016-11-29T08:32:37Z

spec/helpers/agency_people_helper_spec.rb

                          to match_array [adam, bob, charles, dave]
    end
    it 'returns job seekers for case manager role' do
-      expect(eligible_job_seekers_for_role(cm_person, :CM)).
+      expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :CM)).


Place the . on the next line, together with the method name.

houndci-bot · 2016-11-29T08:32:37Z

spec/helpers/agency_people_helper_spec.rb

                          to match_array [adam, bob, charles]

-      expect(eligible_job_seekers_for_role(jd_person, :JD)).
+      expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :JD)).


Place the . on the next line, together with the method name.

houndci-bot · 2016-11-29T08:32:37Z

spec/helpers/agency_people_helper_spec.rb

@@ -87,17 +87,17 @@
      jd_person.save!
    end
    it 'returns job seekers for job developer role' do
-      expect(eligible_job_seekers_for_role(cm_person, :JD)).
+      expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)).


Place the . on the next line, together with the method name.

We have set our rubocop preferences such that a statement - like this - that continues on a subsequent line should have the . method separator on the next line, next to the method. Thus:

expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)). to match_array [adam, bob, charles]

should be

expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)) .to match_array [adam, bob, charles]

lollypop27 · 2016-11-29T11:39:58Z

@patmbolger and @joaopapereira ready for review

patmbolger

Reviewed - looks good, but please accommodate the Rubocop suggestion re extending a statement across 2 or more lines.

patmbolger · 2016-11-30T12:01:31Z

spec/helpers/agency_people_helper_spec.rb

@@ -87,17 +87,17 @@
      jd_person.save!
    end
    it 'returns job seekers for job developer role' do
-      expect(eligible_job_seekers_for_role(cm_person, :JD)).
+      expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)).


We have set our rubocop preferences such that a statement - like this - that continues on a subsequent line should have the . method separator on the next line, next to the method. Thus:

expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)). to match_array [adam, bob, charles]

should be

expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD)) .to match_array [adam, bob, charles]

joaopapereira

Looks good, Please follow Rubocup suggestions and we should be good

houndci-bot · 2016-12-01T11:01:13Z

spec/helpers/agency_people_helper_spec.rb

-      expect(eligible_job_seekers_for_role(jd_person, :CM)).
-                          to match_array [bob, charles, dave]
+      expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :CM))
+                          .to match_array [bob, charles, dave]


Use 2 (not 20) spaces for indenting an expression spanning multiple lines.

Fix one thing and another pops up :)

Anyway, rubocop wants this:

expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :CM)) .to match_array [bob, charles, dave]

to look like this:

expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :CM)) .to match_array [bob, charles, dave]

houndci-bot · 2016-12-01T11:01:13Z

spec/helpers/agency_people_helper_spec.rb

-      expect(eligible_job_seekers_for_role(cm_person, :CM)).
-                          to match_array [adam, bob, dave, charles]
+      expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :CM))
+                          .to match_array [adam, bob, dave, charles]


Use 2 (not 20) spaces for indenting an expression spanning multiple lines.

houndci-bot · 2016-12-01T11:01:13Z

spec/helpers/agency_people_helper_spec.rb

-      expect(eligible_job_seekers_for_role(jd_person, :JD)).
-                          to match_array [adam, bob, charles, dave]
+      expect(job_seekers_assigned_or_assignable_to_ap(jd_person, :JD))
+                          .to match_array [adam, bob, charles, dave]


Use 2 (not 20) spaces for indenting an expression spanning multiple lines.

houndci-bot · 2016-12-01T11:01:13Z

spec/helpers/agency_people_helper_spec.rb

-      expect(eligible_job_seekers_for_role(cm_person, :JD)).
-                          to match_array [adam, bob, charles]
+      expect(job_seekers_assigned_or_assignable_to_ap(cm_person, :JD))
+                          .to match_array [adam, bob, charles]


Use 2 (not 20) spaces for indenting an expression spanning multiple lines.

lollypop27 · 2016-12-03T07:08:07Z

@joaopapereira and @patmbolger ready for review

patmbolger

PR looks good (even hound is happy!)

joaopapereira

Looks good

* Closes AgileVentures/MetPlus_tracker#476 (#448) * non-agency person redirected if trying to access agency admin home page * adjustments on non-agency person redirected if trying to access agency admin home page * correct AgencyPolicy#update? method * Closes AgileVentures/MetPlus_tracker#441 (#446) * remove company_person's hidden_tag when create job * combine _compact_list,_list_all to _list_jobs & update jobs_controller & jobs_viewer * improve jobs_controller readability * initial change to spec files * initial commit on authorize job * update authorize job policy & spec files * add pending test * update address factory * initial clean up view/jobs * correct indentation error * update broken view * correct mistake * update jobs_controller_spec * update houndci * update company_registrations spec files * update job features * update houndci * update houndci * update job_application_viewer after houndci updates * update spec & feature files * update feature file * initial review change * complete review changes * clean up codes * clear houndci * update to pass feature test * update job_policy_spec * Closes AgileVentures/MetPlus_tracker#496 fix postgresql migrations (#450) * Closes AgileVentures/MetPlus_tracker#479 (#440) * Setup Jasmine for JavaScript Testing * Add spec file for testing Remove duplicated jasmine gem * Setup test for UTC to Local time * Add test for UTC to Local time * Add var before ele and define var top of page * update to fix failing scenario * Closes AgileVentures/MetPlus_tracker#478 (#447) * update _applied_jobs_list partial * fix failing features * change indent tabs to spaces * fix failing spec * fix failing features * fix failing view_job_application.feature * update job_seekers_controller * dry code in job_application_viewer * update houndci * update job_application.feature * Add step file * changed selenium to poltergeist tests * pre-fetch commit * Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned (#451) * Refactor eleigible job seeker to job seeker assigned * Fixes hound errors * Refactor space issues * converted tests to poltergeist * added waits * more waits * added minimum expected for select find() * reduce wait time * increased poltergeist timeout param * changed comment to prefer poltergeist over selenium * added explicit labels for fields * Closes AgileVentures/MetPlus_tracker#462 (#455) * fix git merge conflict * Adds Jasmine test for job_applications.js * Corrects filname error and rearranges spec * added back selenium for 2 scenarios * Closes AgileVentures/MetPlus_tracker#411 (#452) * interim progress * interim progress * interim progress * added tests for instance method, rubocop fixes * added spinner * controller tests * added auth tests * rspec controller tests * rubocop fixes * rubocop fixes * houndci fixes job.css * more houndci fixes * yet more houndci fixes * backed out changes to jobs form * changed tabs to spaces * For Pull Request * Closes AgileVentures/MetPlus_tracker#412 (#461) * interim progress * added task creation * added policy test * wip - adding tests * more rspec tests * added cuke test, renamed feature file * removed cuke step * rubocop fixes * corrected action * rubocop fixes * added comment (#464) * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * Closes AgileVentures/MetPlus_tracker#509 (#465) * Add missing tests for OTHER JD APPLY * Change to 2 spaces * Closes AgileVentures/MetPlus_tracker#500 (#468) Refactor create and update in jobs_controller * Closes AgileVentures/MetPlus_tracker#508 (#466) * parameter for agency admin email * remove rspec example file * corrected from-address * 506 PR * add counter_cache to job_skills * add test to skill_spec * update houndci violations * ignore example.txt and Editor file * added wait for 2 tests * removed 100 year old birth date from test * jobseeker notifications * changes to event.rb * add notification to jobseeker * fixing errors * rubocop implement * remove extra spaces * added new method app for job * created new jobseeker mailer revoke * added event * add method jobseekermailer * Created new jonseeker preview mailer * Remove spaces * rubo implement * Add action for job developer to match job seekers against a job * Resolve rubo issues * updates for spec * Resolve issues rspec test * Add job policy and policy specs * Refactor code and fix rubocop violations * migrate seed and updates event * removed Factory creation * Resolved conflicts * changes for jobseeker templateview * Handle nil job_seeker_ids Fixes the issue when a user bypasses the javascript validation and force submits the form without selecting a job seeker * Add controller tests * fix rspec test * Resolved mergeconflicts * increased capybara wait time * Fixed rspec test * Add cuke tests * Resolve bug caused when agency person updates his/her email address Fix minor rubocop warnings in controller and controller spec * Remove job category placeholder from job_info view closes issue #498 * Flash message when updating email address (#477) * added crucher stub files (#475) * added crucher stub files * updates and rebase code * fixed errors * Changed Flash message for Company person email update * UI Assets (#481) * company people rspec * All changes for #514 pull request * push changes * prior to pul request * Corrected Jobs Search Feature Tests * Corrected HoundCI issues * Cucumber File fix * Rebase to origin * restored company jobs edit revoke list * fixed some hound issues * semaphore corrections * corrected jobs_controller_spec tests * some index.html.haml hound issues * changes to footer * removal of company_jobs list * remove edit and revoke buttons from jobs search list * git hound corrections * corrections to features * corrections to jobs_steps.rb and layout/_footer.html.haml * corrections to jobs_controller and _search_job.html.haml * fixed layouts/_footer.html.haml

Refactor eleigible job seeker to job seeker assigned

71ab567

joaopapereira added the Need Review label Nov 29, 2016

houndci-bot reviewed Nov 29, 2016

View reviewed changes

patmbolger requested changes Nov 30, 2016

View reviewed changes

joaopapereira requested changes Nov 30, 2016

View reviewed changes

joaopapereira changed the title ~~281 Refactor eleigible job seeker to job seeker assigned~~ Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned Nov 30, 2016

Fixes hound errors

05e712b

houndci-bot reviewed Dec 1, 2016

View reviewed changes

Refactor space issues

86ab965

patmbolger approved these changes Dec 3, 2016

View reviewed changes

joaopapereira approved these changes Dec 3, 2016

View reviewed changes

joaopapereira merged commit c686698 into AgileVentures:development Dec 3, 2016

joaopapereira removed the Need Review label Dec 3, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned #451

Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned #451

lollypop27 commented Nov 29, 2016

houndci-bot Nov 29, 2016

houndci-bot Nov 29, 2016

houndci-bot Nov 29, 2016

houndci-bot Nov 29, 2016

patmbolger Nov 30, 2016

lollypop27 commented Nov 29, 2016

patmbolger left a comment

patmbolger Nov 30, 2016

joaopapereira left a comment

houndci-bot Dec 1, 2016

patmbolger Dec 1, 2016

houndci-bot Dec 1, 2016

houndci-bot Dec 1, 2016

houndci-bot Dec 1, 2016

lollypop27 commented Dec 3, 2016

patmbolger left a comment

joaopapereira left a comment

Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned #451

Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned #451

Conversation

lollypop27 commented Nov 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lollypop27 commented Nov 29, 2016

patmbolger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaopapereira left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lollypop27 commented Dec 3, 2016

patmbolger left a comment

Choose a reason for hiding this comment

joaopapereira left a comment

Choose a reason for hiding this comment