Closes AgileVentures/MetPlus_tracker#520 #498

hin101 · 2017-02-01T21:29:23Z

My Profile Page

houndci-bot · 2017-02-01T21:29:40Z

app/views/layouts/_menu.html.haml

                  - elsif current_user.actable_type == 'AgencyPerson'
-                    = link_to 'Edit Profile', edit_profile_agency_person_path(current_user.actable_id)
+                    = link_to 'My Profile', my_profile_agency_person_path(current_user.actable_id)


Line is too long. [98/90]

houndci-bot · 2017-02-01T21:29:41Z

app/views/layouts/_menu.html.haml

                  - elsif current_user.actable_type == 'CompanyPerson'
-                    = link_to 'Edit Profile', edit_profile_company_person_path(current_user.actable_id)
+                    = link_to 'My Profile', my_profile_company_person_path(current_user.actable_id)


Line is too long. [99/90]

houndci-bot · 2017-02-01T21:29:41Z

app/views/layouts/_menu.html.haml

@@ -45,11 +45,11 @@
              %ul.dropdown-menu{ 'aria-labelledby' => 'dd_menu' }
                %li
                  - if current_user.actable_type == 'JobSeeker'
-                    = link_to 'Edit Profile', edit_job_seeker_path(current_user.actable_id)
+                    = link_to 'My Profile', my_profile_job_seeker_path(current_user.actable_id)


Line is too long. [95/90]

houndci-bot · 2017-02-01T21:29:42Z

app/views/layouts/_menu.html.haml

@@ -10,7 +10,7 @@
        %li{:class => "menu-item #{ yield(:job_active) }"}
          %a{:href => '/jobs', id: 'job'} Jobs
        %li{ :class => "menu-item #{ yield(:about_active) }" }
-          %a{:href => '#', id: 'about'} About
+          %a{:href => '/about', id: 'about'} About


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2017-02-01T21:29:43Z

app/views/job_seekers/my_profile.html.haml

+    %h4
+      %strong Phone:
+      = @jobseeker.phone
+    = link_to "Edit", edit_job_seeker_path(@jobseeker), class: "btn btn-lg edit-profile-btn"


Files should end with a trailing newline
Line is too long. [92/90]

houndci-bot · 2017-02-01T21:29:43Z

app/views/job_seekers/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row
+  %div.col-md-4


%div.col-md-4 can be written as .col-md-4 since %div is implicit

houndci-bot · 2017-02-01T21:29:43Z

app/views/job_seekers/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row


%div.row can be written as .row since %div is implicit

houndci-bot · 2017-02-01T21:29:44Z

app/views/company_people/my_profile.html.haml

+    %h4
+      %strong Phone:
+      = @company_person.phone
+    = link_to "Edit", edit_profile_company_person_path(@company_person), class: "btn btn-lg edit-profile-btn"


Line is too long. [109/90]
Files should end with a trailing newline

houndci-bot · 2017-02-01T21:29:45Z

app/views/company_people/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row
+  %div.col-md-4


%div.col-md-4 can be written as .col-md-4 since %div is implicit

houndci-bot · 2017-02-01T21:29:45Z

app/views/company_people/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row


%div.row can be written as .row since %div is implicit

houndci-bot · 2017-02-01T21:29:46Z

app/views/agency_people/my_profile.html.haml

+    %h4
+      %strong Phone:
+      = @agency_person.phone
+    = link_to "Edit", edit_profile_agency_person_path(@agency_person), class: "btn btn-lg edit-profile-btn"


Line is too long. [107/90]
Files should end with a trailing newline

houndci-bot · 2017-02-01T21:29:46Z

app/views/agency_people/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row
+  %div.col-md-4


%div.col-md-4 can be written as .col-md-4 since %div is implicit

houndci-bot · 2017-02-01T21:29:47Z

app/views/agency_people/my_profile.html.haml

@@ -0,0 +1,16 @@
+%div.row


%div.row can be written as .row since %div is implicit

houndci-bot · 2017-02-01T21:29:47Z

app/policies/company_person_policy.rb

@@ -26,6 +26,11 @@ def home?
  def update_profile?
    user.is_company_person? record.company and user == record
  end
+
+  def my_profile?
+    (agency_admin? user and agency_related_to_company?(user.agency, record.company)) or


Use && instead of and.
Use || instead of or.

houndci-bot · 2017-02-01T21:29:48Z

app/policies/agency_person_policy.rb

+  def my_profile?
+    user.is_agency_person? record.agency
+  end
+


Extra empty line detected at class body end.

houndci-bot · 2017-02-01T21:29:48Z

app/assets/stylesheets/user.scss

+	font-size: 48px;
+	color: #0c7ba1;
+	font-weight: 700;
+	padding-bottom: 20px;


Line should be indented with spaces, not tabs

houndci-bot · 2017-02-01T21:30:34Z

app/assets/stylesheets/user.scss

+.my-profile-header {
+	font-size: 48px;
+	color: #0c7ba1;
+	font-weight: 700;


Line should be indented with spaces, not tabs

houndci-bot · 2017-02-01T21:30:35Z

app/assets/stylesheets/user.scss

+.my-profile-header {
+	font-size: 48px;
+	color: #0c7ba1;
+	font-weight: 700;


Line should be indented with spaces, not tabs

patmbolger · 2017-02-02T11:27:19Z

Looking at this I think we want to change the design a little - to better reflect the data items that the user can edit in their profile.

For a job seeker, these are the items that can be edited:

So, these items should be listed on the "My Profile" page.

On the profile page, I recommend just listing the full name (as shown above) as opposed to separate first name and surname. (the profile edit page, of course, separates those out).
The item name (e.g. "Email") should be in bold, and the item value should not be in bold.
Also, I think it looks better to left justify each column as shown above.
Similar to the above items for company person profile. Show these items (plus address):

Similar comments as above for an agency person.

lollypop27 · 2017-02-03T11:37:41Z

@hin101 good job thank you. Over and above @patmbolger changes please can you make sure that the form is centred left and right on the page, at the moment the space on the left of the page is less than the right of the page. Thank you.

houndci-bot · 2017-02-03T21:00:56Z

app/views/job_seekers/my_profile.html.haml

+              %span.utc_to_local_time= @current_resume.updated_at
+            - else
+              You have no current resume
+    = link_to "Edit", edit_job_seeker_path(@jobseeker), class: "btn btn-lg edit-profile-btn"


Line is too long. [92/90]

houndci-bot · 2017-02-03T21:00:56Z

app/views/job_seekers/edit.html.haml

@@ -1,6 +1,6 @@
 %div{class:'row'}
 	%div{class:'col-sm-8 col-sm-offset-2'}
-		%h1 Edit JobSeeker Registration
+		%h1 Update Your Profile


Line contains tabs in indentation

houndci-bot · 2017-02-03T21:00:57Z

app/views/company_people/my_profile.html.haml

+          %td
+            %strong Phone
+          %td= @company_person.phone
+    = link_to "Edit", edit_profile_company_person_path(@company_person), class: "btn btn-lg edit-profile-btn"


Line is too long. [109/90]

houndci-bot · 2017-02-03T21:00:57Z

app/views/agency_people/my_profile.html.haml

+          %td
+            %strong Phone
+          %td= @agency_person.phone
+    = link_to "Edit", edit_profile_agency_person_path(@agency_person), class: "btn btn-lg edit-profile-btn"


Line is too long. [107/90]

houndci-bot · 2017-02-03T21:00:57Z

app/assets/stylesheets/user.scss

+
+.my-profile-header {
+	font-size: 48px;
+	color: #0c7ba1;


Line should be indented with spaces, not tabs
Color literals like #0c7ba1 should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-02-03T21:00:58Z

app/assets/stylesheets/user.scss

+}
+
+.my-profile-header {
+	font-size: 48px;


Line should be indented with spaces, not tabs
Properties should be ordered color, font-size, font-weight, padding-bottom

houndci-bot · 2017-02-03T21:00:58Z

app/assets/stylesheets/user.scss

+    width: 250px;
+    margin-top: 20px;
+    &:hover {
+      color: #fff;


Color literals like #fff should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2017-02-03T21:00:58Z

app/assets/stylesheets/user.scss

+    padding: 12px 16px;
+    width: 250px;
+    margin-top: 20px;
+    &:hover {


Rule declaration should be preceded by an empty line
Line should be indented 2 spaces, but was indented 4 spaces

houndci-bot · 2017-02-03T21:00:59Z

app/assets/stylesheets/user.scss

+    height: 50px;
+    padding: 12px 16px;
+    width: 250px;
+    margin-top: 20px;


Line should be indented 2 spaces, but was indented 4 spaces

houndci-bot · 2017-02-04T13:32:24Z

app/assets/stylesheets/user.scss

+    font-weight: bold;
+    height: 50px;
+    padding: 12px 16px;
+    width: 250px;


Line should be indented 2 spaces, but was indented 4 spaces

patmbolger

Almost there - please see comments and also Lara's comment about centering the profile information on the page (horizontal centering).

patmbolger · 2017-02-04T21:25:14Z

app/controllers/job_seekers_controller.rb

@@ -96,6 +96,7 @@ def update
  end

  def home
+    logger.info("Person: #{pets_user.inspect}")


This looks like a holdover from development(?)

patmbolger · 2017-02-04T21:29:38Z

app/views/job_seekers/my_profile.html.haml

+              %span.utc_to_local_time= @current_resume.updated_at
+            - else
+              You have no current resume
+    = link_to "Edit", edit_job_seeker_path(@jobseeker), class: "btn btn-lg edit-profile-btn"


We're missing address in this view.

houndci-bot · 2017-02-05T16:24:03Z

app/views/job_seekers/my_profile.html.haml

+            %td
+              %strong Address
+            %td= @jobseeker.address.street + ', ' + @jobseeker.address.city + ', ' + @jobseeker.address.zipcode
+    = link_to "Edit", edit_job_seeker_path(@jobseeker), class: "btn btn-lg edit-profile-btn"


Line is too long. [92/90]

houndci-bot · 2017-02-05T16:24:03Z

app/views/job_seekers/my_profile.html.haml

+          %tr
+            %td
+              %strong Address
+            %td= @jobseeker.address.street + ', ' + @jobseeker.address.city + ', ' + @jobseeker.address.zipcode


Line is too long. [111/90]

patmbolger · 2017-02-07T12:58:26Z

Please make these changes to the profile view:

For job seeker, add "status"
For company person, add "address"

houndci-bot · 2017-02-07T20:26:42Z

app/views/job_seekers/my_profile.html.haml

+          %td
+            %strong Status
+          %td= @jobseeker.status.short_description
+    = link_to "Edit", edit_job_seeker_path(@jobseeker), class: "btn btn-lg edit-profile-btn"


Line is too long. [92/90]

houndci-bot · 2017-02-07T20:26:43Z

app/views/company_people/my_profile.html.haml

+          %td
+            %strong Address
+          %td= @company_person.address.street + ', ' + @company_person.address.city + ', ' + @company_person.address.zipcode
+    = link_to "Edit", edit_profile_company_person_path(@company_person), class: "btn btn-lg edit-profile-btn"


Line is too long. [109/90]

houndci-bot · 2017-02-07T20:26:43Z

app/views/company_people/my_profile.html.haml

+        %tr
+          %td
+            %strong Address
+          %td= @company_person.address.street + ', ' + @company_person.address.city + ', ' + @company_person.address.zipcode


Line is too long. [124/90]

* changed selenium to poltergeist tests * converted tests to poltergeist * added waits * more waits * added minimum expected for select find() * reduce wait time * increased poltergeist timeout param * changed comment to prefer poltergeist over selenium * added explicit labels for fields * added back selenium for 2 scenarios * backed out changes to jobs form * changed tabs to spaces * Closes AgileVentures/MetPlus_tracker#412 (#461) * interim progress * added task creation * added policy test * wip - adding tests * more rspec tests * added cuke test, renamed feature file * removed cuke step * rubocop fixes * corrected action * rubocop fixes * added comment (#464) * Closes AgileVentures/MetPlus_tracker#509 (#465) * Add missing tests for OTHER JD APPLY * Change to 2 spaces * Closes AgileVentures/MetPlus_tracker#500 (#468) Refactor create and update in jobs_controller * Closes AgileVentures/MetPlus_tracker#487 refactor download resume (#456) * Add step file * pre-fetch commit * For Pull Request * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * Closes AgileVentures/MetPlus_tracker#508 (#466) * parameter for agency admin email * remove rspec example file * corrected from-address * add counter_cache to job_skills * add test to skill_spec * update houndci violations * made all emails valid for cuke tests * added wait for 2 tests * removed 100 year old birth date from test * increased capybara wait time * jobseeker notifications * changes to event.rb * add notification to jobseeker * fixing errors * rubocop implement * remove extra spaces * added new method app for job * created new jobseeker mailer revoke * added event * add method jobseekermailer * Created new jonseeker preview mailer * Remove spaces * rubo implement * Resolve rubo issues * updates for spec * Resolve issues rspec test * migrate seed and updates event * removed Factory creation * Resolved conflicts * changes for jobseeker templateview * fix rspec test * Resolved mergeconflicts * Add action for job developer to match job seekers against a job * Add job policy and policy specs * Refactor code and fix rubocop violations * Handle nil job_seeker_ids Fixes the issue when a user bypasses the javascript validation and force submits the form without selecting a job seeker * Add controller tests * Fixed rspec test * removed 100 year old birth date from test * increased capybara wait time * Remove job category placeholder from job_info view closes issue #498 * Resolve bug caused when agency person updates his/her email address Fix minor rubocop warnings in controller and controller spec * Add cuke tests * Flash message when updating email address (#477) * added crucher stub files (#475) * added crucher stub files * updates and rebase code * fixed errors * UI Assets (#481) * 506 company person profile update (#476) * Add step file * pre-fetch commit * For Pull Request * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * 506 PR * remover byebug from email validator * fixed job_seeker_spec dob validation * Changed Flash message for Company person email update * company people rspec * Closes AgileVentures/MetPlus_tracker#522 (#479) * Change from Update Agency Person/Update Company Person to Update Profile * fix failing cucumber tests * Closes AgileVentures/MetPlus_tracker#477 (#459) * Closes AgileVentures/MetPlus_tracker#477 * update reviews from PR * handle nil jobseeker address attributes * make address_is_empty method take a parameter Makes it clear we are checking job_seeker_params for presence of address attributes * test address attributes for job_seeker while editing * resolve merge conflict * make tests pass * WIP: speed up cucumber tests (#487) * added code from website one * db clean strategy, refactor cuke scenarios * changes to speed up cuke tests * Closes AgileVentures/MetPlus_tracker#533 (#488) * added wait for XHR request completion * increased wait time * Stub external services (#483) * fixed spelling of raise (#489) * Js update 517 (#485) * updates for js * updates for seed and job_seeker feature * fixed links * updates for jsfeature

* Closes AgileVentures/MetPlus_tracker#476 (#448) * non-agency person redirected if trying to access agency admin home page * adjustments on non-agency person redirected if trying to access agency admin home page * correct AgencyPolicy#update? method * Closes AgileVentures/MetPlus_tracker#441 (#446) * remove company_person's hidden_tag when create job * combine _compact_list,_list_all to _list_jobs & update jobs_controller & jobs_viewer * improve jobs_controller readability * initial change to spec files * initial commit on authorize job * update authorize job policy & spec files * add pending test * update address factory * initial clean up view/jobs * correct indentation error * update broken view * correct mistake * update jobs_controller_spec * update houndci * update company_registrations spec files * update job features * update houndci * update houndci * update job_application_viewer after houndci updates * update spec & feature files * update feature file * initial review change * complete review changes * clean up codes * clear houndci * update to pass feature test * update job_policy_spec * Closes AgileVentures/MetPlus_tracker#496 fix postgresql migrations (#450) * Closes AgileVentures/MetPlus_tracker#479 (#440) * Setup Jasmine for JavaScript Testing * Add spec file for testing Remove duplicated jasmine gem * Setup test for UTC to Local time * Add test for UTC to Local time * Add var before ele and define var top of page * update to fix failing scenario * Closes AgileVentures/MetPlus_tracker#478 (#447) * update _applied_jobs_list partial * fix failing features * change indent tabs to spaces * fix failing spec * fix failing features * fix failing view_job_application.feature * update job_seekers_controller * dry code in job_application_viewer * update houndci * update job_application.feature * Add step file * changed selenium to poltergeist tests * pre-fetch commit * Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned (#451) * Refactor eleigible job seeker to job seeker assigned * Fixes hound errors * Refactor space issues * converted tests to poltergeist * added waits * more waits * added minimum expected for select find() * reduce wait time * increased poltergeist timeout param * changed comment to prefer poltergeist over selenium * added explicit labels for fields * Closes AgileVentures/MetPlus_tracker#462 (#455) * fix git merge conflict * Adds Jasmine test for job_applications.js * Corrects filname error and rearranges spec * added back selenium for 2 scenarios * Closes AgileVentures/MetPlus_tracker#411 (#452) * interim progress * interim progress * interim progress * added tests for instance method, rubocop fixes * added spinner * controller tests * added auth tests * rspec controller tests * rubocop fixes * rubocop fixes * houndci fixes job.css * more houndci fixes * yet more houndci fixes * backed out changes to jobs form * changed tabs to spaces * For Pull Request * Closes AgileVentures/MetPlus_tracker#412 (#461) * interim progress * added task creation * added policy test * wip - adding tests * more rspec tests * added cuke test, renamed feature file * removed cuke step * rubocop fixes * corrected action * rubocop fixes * added comment (#464) * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * Closes AgileVentures/MetPlus_tracker#509 (#465) * Add missing tests for OTHER JD APPLY * Change to 2 spaces * Closes AgileVentures/MetPlus_tracker#500 (#468) Refactor create and update in jobs_controller * Closes AgileVentures/MetPlus_tracker#508 (#466) * parameter for agency admin email * remove rspec example file * corrected from-address * 506 PR * add counter_cache to job_skills * add test to skill_spec * update houndci violations * ignore example.txt and Editor file * added wait for 2 tests * removed 100 year old birth date from test * jobseeker notifications * changes to event.rb * add notification to jobseeker * fixing errors * rubocop implement * remove extra spaces * added new method app for job * created new jobseeker mailer revoke * added event * add method jobseekermailer * Created new jonseeker preview mailer * Remove spaces * rubo implement * Add action for job developer to match job seekers against a job * Resolve rubo issues * updates for spec * Resolve issues rspec test * Add job policy and policy specs * Refactor code and fix rubocop violations * migrate seed and updates event * removed Factory creation * Resolved conflicts * changes for jobseeker templateview * Handle nil job_seeker_ids Fixes the issue when a user bypasses the javascript validation and force submits the form without selecting a job seeker * Add controller tests * fix rspec test * Resolved mergeconflicts * increased capybara wait time * Fixed rspec test * Add cuke tests * Resolve bug caused when agency person updates his/her email address Fix minor rubocop warnings in controller and controller spec * Remove job category placeholder from job_info view closes issue #498 * Flash message when updating email address (#477) * added crucher stub files (#475) * added crucher stub files * updates and rebase code * fixed errors * Changed Flash message for Company person email update * UI Assets (#481) * company people rspec * All changes for #514 pull request * push changes * prior to pul request * Corrected Jobs Search Feature Tests * Corrected HoundCI issues * Cucumber File fix * Rebase to origin * restored company jobs edit revoke list * fixed some hound issues * semaphore corrections * corrected jobs_controller_spec tests * some index.html.haml hound issues * changes to footer * removal of company_jobs list * remove edit and revoke buttons from jobs search list * git hound corrections * corrections to features * corrections to jobs_steps.rb and layout/_footer.html.haml * corrections to jobs_controller and _search_job.html.haml * fixed layouts/_footer.html.haml

My profile page

529b4e4

joaopapereira added the Need Review label Feb 1, 2017

houndci-bot reviewed Feb 1, 2017

View reviewed changes

app/views/job_seekers/my_profile.html.haml Outdated

@@ -0,0 +1,16 @@

%div.row

Copy link

houndci-bot Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%div.row can be written as .row since %div is implicit

houndci-bot reviewed Feb 1, 2017

View reviewed changes

Merge branch 'development' into my_profile_page_#520

47e3a2f

houndci-bot reviewed Feb 1, 2017

View reviewed changes

code review changes

f17420c

houndci-bot reviewed Feb 3, 2017

View reviewed changes

fix failing cucumber test

6c7386e

houndci-bot reviewed Feb 4, 2017

View reviewed changes

patmbolger requested changes Feb 4, 2017

View reviewed changes

Code Review Changes

5155273

houndci-bot reviewed Feb 5, 2017

View reviewed changes

Further code review changes

a9d78f1

houndci-bot reviewed Feb 7, 2017

View reviewed changes

patmbolger merged commit ec4edb1 into AgileVentures:development Feb 8, 2017

patmbolger removed the Need Review label Feb 8, 2017

joaopapereira mentioned this pull request Feb 13, 2017

End of Sprint 35 #505

Merged

joaopapereira pushed a commit that referenced this pull request Feb 14, 2017

Remove job category placeholder from job_info view closes issue #498

d4e05ad

hin101 deleted the my_profile_page_#520 branch October 10, 2017 10:05

Closes AgileVentures/MetPlus_tracker#520 #498

Closes AgileVentures/MetPlus_tracker#520 #498

Conversation

hin101 commented Feb 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patmbolger commented Feb 2, 2017

lollypop27 commented Feb 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patmbolger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patmbolger commented Feb 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment