Closes AgileVentures/MetPlus_tracker#500 #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmbolger
pushed a commit
that referenced
this pull request
Jan 27, 2017
* changed selenium to poltergeist tests * converted tests to poltergeist * added waits * more waits * added minimum expected for select find() * reduce wait time * increased poltergeist timeout param * changed comment to prefer poltergeist over selenium * added explicit labels for fields * added back selenium for 2 scenarios * backed out changes to jobs form * changed tabs to spaces * Closes AgileVentures/MetPlus_tracker#412 (#461) * interim progress * added task creation * added policy test * wip - adding tests * more rspec tests * added cuke test, renamed feature file * removed cuke step * rubocop fixes * corrected action * rubocop fixes * added comment (#464) * Closes AgileVentures/MetPlus_tracker#509 (#465) * Add missing tests for OTHER JD APPLY * Change to 2 spaces * Closes AgileVentures/MetPlus_tracker#500 (#468) Refactor create and update in jobs_controller * Closes AgileVentures/MetPlus_tracker#487 refactor download resume (#456) * Add step file * pre-fetch commit * For Pull Request * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * Closes AgileVentures/MetPlus_tracker#508 (#466) * parameter for agency admin email * remove rspec example file * corrected from-address * add counter_cache to job_skills * add test to skill_spec * update houndci violations * made all emails valid for cuke tests * added wait for 2 tests * removed 100 year old birth date from test * increased capybara wait time * jobseeker notifications * changes to event.rb * add notification to jobseeker * fixing errors * rubocop implement * remove extra spaces * added new method app for job * created new jobseeker mailer revoke * added event * add method jobseekermailer * Created new jonseeker preview mailer * Remove spaces * rubo implement * Resolve rubo issues * updates for spec * Resolve issues rspec test * migrate seed and updates event * removed Factory creation * Resolved conflicts * changes for jobseeker templateview * fix rspec test * Resolved mergeconflicts * Add action for job developer to match job seekers against a job * Add job policy and policy specs * Refactor code and fix rubocop violations * Handle nil job_seeker_ids Fixes the issue when a user bypasses the javascript validation and force submits the form without selecting a job seeker * Add controller tests * Fixed rspec test * removed 100 year old birth date from test * increased capybara wait time * Remove job category placeholder from job_info view closes issue #498 * Resolve bug caused when agency person updates his/her email address Fix minor rubocop warnings in controller and controller spec * Add cuke tests * Flash message when updating email address (#477) * added crucher stub files (#475) * added crucher stub files * updates and rebase code * fixed errors * UI Assets (#481) * 506 company person profile update (#476) * Add step file * pre-fetch commit * For Pull Request * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * 506 PR * remover byebug from email validator * fixed job_seeker_spec dob validation * Changed Flash message for Company person email update * company people rspec * Closes AgileVentures/MetPlus_tracker#522 (#479) * Change from Update Agency Person/Update Company Person to Update Profile * fix failing cucumber tests * Closes AgileVentures/MetPlus_tracker#477 (#459) * Closes AgileVentures/MetPlus_tracker#477 * update reviews from PR * handle nil jobseeker address attributes * make address_is_empty method take a parameter Makes it clear we are checking job_seeker_params for presence of address attributes * test address attributes for job_seeker while editing * resolve merge conflict * make tests pass * WIP: speed up cucumber tests (#487) * added code from website one * db clean strategy, refactor cuke scenarios * changes to speed up cuke tests * Closes AgileVentures/MetPlus_tracker#533 (#488) * added wait for XHR request completion * increased wait time * Stub external services (#483) * fixed spelling of raise (#489) * Js update 517 (#485) * updates for js * updates for seed and job_seeker feature * fixed links * updates for jsfeature
Merged
patmbolger
pushed a commit
that referenced
this pull request
Feb 17, 2017
* Closes AgileVentures/MetPlus_tracker#476 (#448) * non-agency person redirected if trying to access agency admin home page * adjustments on non-agency person redirected if trying to access agency admin home page * correct AgencyPolicy#update? method * Closes AgileVentures/MetPlus_tracker#441 (#446) * remove company_person's hidden_tag when create job * combine _compact_list,_list_all to _list_jobs & update jobs_controller & jobs_viewer * improve jobs_controller readability * initial change to spec files * initial commit on authorize job * update authorize job policy & spec files * add pending test * update address factory * initial clean up view/jobs * correct indentation error * update broken view * correct mistake * update jobs_controller_spec * update houndci * update company_registrations spec files * update job features * update houndci * update houndci * update job_application_viewer after houndci updates * update spec & feature files * update feature file * initial review change * complete review changes * clean up codes * clear houndci * update to pass feature test * update job_policy_spec * Closes AgileVentures/MetPlus_tracker#496 fix postgresql migrations (#450) * Closes AgileVentures/MetPlus_tracker#479 (#440) * Setup Jasmine for JavaScript Testing * Add spec file for testing Remove duplicated jasmine gem * Setup test for UTC to Local time * Add test for UTC to Local time * Add var before ele and define var top of page * update to fix failing scenario * Closes AgileVentures/MetPlus_tracker#478 (#447) * update _applied_jobs_list partial * fix failing features * change indent tabs to spaces * fix failing spec * fix failing features * fix failing view_job_application.feature * update job_seekers_controller * dry code in job_application_viewer * update houndci * update job_application.feature * Add step file * changed selenium to poltergeist tests * pre-fetch commit * Closes AgileVentures/MetPlus_tracker#281 Refactor eleigible job seeker to job seeker assigned (#451) * Refactor eleigible job seeker to job seeker assigned * Fixes hound errors * Refactor space issues * converted tests to poltergeist * added waits * more waits * added minimum expected for select find() * reduce wait time * increased poltergeist timeout param * changed comment to prefer poltergeist over selenium * added explicit labels for fields * Closes AgileVentures/MetPlus_tracker#462 (#455) * fix git merge conflict * Adds Jasmine test for job_applications.js * Corrects filname error and rearranges spec * added back selenium for 2 scenarios * Closes AgileVentures/MetPlus_tracker#411 (#452) * interim progress * interim progress * interim progress * added tests for instance method, rubocop fixes * added spinner * controller tests * added auth tests * rspec controller tests * rubocop fixes * rubocop fixes * houndci fixes job.css * more houndci fixes * yet more houndci fixes * backed out changes to jobs form * changed tabs to spaces * For Pull Request * Closes AgileVentures/MetPlus_tracker#412 (#461) * interim progress * added task creation * added policy test * wip - adding tests * more rspec tests * added cuke test, renamed feature file * removed cuke step * rubocop fixes * corrected action * rubocop fixes * added comment (#464) * re-commit * Active Jobs * AR Not Found Exception * removed unused instance variable * Closes AgileVentures/MetPlus_tracker#509 (#465) * Add missing tests for OTHER JD APPLY * Change to 2 spaces * Closes AgileVentures/MetPlus_tracker#500 (#468) Refactor create and update in jobs_controller * Closes AgileVentures/MetPlus_tracker#508 (#466) * parameter for agency admin email * remove rspec example file * corrected from-address * 506 PR * add counter_cache to job_skills * add test to skill_spec * update houndci violations * ignore example.txt and Editor file * added wait for 2 tests * removed 100 year old birth date from test * jobseeker notifications * changes to event.rb * add notification to jobseeker * fixing errors * rubocop implement * remove extra spaces * added new method app for job * created new jobseeker mailer revoke * added event * add method jobseekermailer * Created new jonseeker preview mailer * Remove spaces * rubo implement * Add action for job developer to match job seekers against a job * Resolve rubo issues * updates for spec * Resolve issues rspec test * Add job policy and policy specs * Refactor code and fix rubocop violations * migrate seed and updates event * removed Factory creation * Resolved conflicts * changes for jobseeker templateview * Handle nil job_seeker_ids Fixes the issue when a user bypasses the javascript validation and force submits the form without selecting a job seeker * Add controller tests * fix rspec test * Resolved mergeconflicts * increased capybara wait time * Fixed rspec test * Add cuke tests * Resolve bug caused when agency person updates his/her email address Fix minor rubocop warnings in controller and controller spec * Remove job category placeholder from job_info view closes issue #498 * Flash message when updating email address (#477) * added crucher stub files (#475) * added crucher stub files * updates and rebase code * fixed errors * Changed Flash message for Company person email update * UI Assets (#481) * company people rspec * All changes for #514 pull request * push changes * prior to pul request * Corrected Jobs Search Feature Tests * Corrected HoundCI issues * Cucumber File fix * Rebase to origin * restored company jobs edit revoke list * fixed some hound issues * semaphore corrections * corrected jobs_controller_spec tests * some index.html.haml hound issues * changes to footer * removal of company_jobs list * remove edit and revoke buttons from jobs search list * git hound corrections * corrections to features * corrections to jobs_steps.rb and layout/_footer.html.haml * corrections to jobs_controller and _search_job.html.haml * fixed layouts/_footer.html.haml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change create and update method in jobs_controller