Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Stream Issue #60

Closed
rlee1990 opened this issue Dec 20, 2021 · 6 comments
Closed

Live Stream Issue #60

rlee1990 opened this issue Dec 20, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@rlee1990
Copy link

Describe the bug
When an audience member joins a live stream as an audience member their view is split with a blank top half even though there is only 1 person broadcasting.

To Reproduce
Steps to reproduce the behavior:
Create a live stream as a broadcaster and have someone view it as an audience member.

Expected behavior
Should just show the broadcaster taking the whole view.

Smartphone (please complete the following information):

  • Device: iPhone 8, Samsung Galaxy Note 8, and Samsung Galaxy Fold 3
  • OS: ios 15
@rlee1990 rlee1990 added the bug Something isn't working label Dec 20, 2021
@rlee1990
Copy link
Author

Here is a photo of what I am referring to image @Meherdeep @tadaspetra

@rlee1990
Copy link
Author

I found that the issue might be with the layout _getRenderViews() function for broadcast calling the

for (AgoraUser user in widget.client.sessionController.value.users) {
      user.videoDisabled
          ? list.add(
              DisabledVideoStfWidget(
                disabledVideoWidget: widget.disabledVideoWidget,
              ),
            )
          : list.add(
              rtc_remote_view.SurfaceView(
                channelId: widget
                    .client.sessionController.value.connectionData!.channelName,
                uid: user.uid,
                renderMode: widget.videoRenderMode,
              ),
            );
    }

@rlee1990
Copy link
Author

@tadaspetra @Meherdeep it seams that when doing Livestreams the audience view is being added as a second view

@rlee1990
Copy link
Author

I found changing the code to this fixed the issue:

if (widget.client.sessionController.value.clientRole !=
        ClientRole.Audience) {
      widget.client.sessionController.value.isLocalVideoDisabled
          ? list.add(
              DisabledVideoStfWidget(
                disabledVideoWidget: widget.disabledVideoWidget,
              ),
            )
          : list.add(
              rtc_local_view.SurfaceView(
                zOrderMediaOverlay: true,
                renderMode: widget.videoRenderMode,
              ),
            );
    }

@Meherdeep
Copy link
Contributor

@rlee1990 Thanks for flagging this. We will update this in our next release or you can submit a PR for the same.

@maxxfrazer
Copy link
Contributor

Looks like this one is fixed now, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants