Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress override mistake with originalValue on getter #476

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Suppress override mistake with originalValue on getter #476

merged 1 commit into from
Sep 27, 2020

Conversation

erights
Copy link
Contributor

@erights erights commented Sep 25, 2020

Rename originalDataPropertyValue to originalValue.

Explain in README and NEWS.

@erights erights mentioned this pull request Sep 25, 2020
Merged
kriskowal
kriskowal approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

@erights erights merged commit 54e0b0c into master Sep 27, 2020
@erights erights deleted the rename-to-originalValue branch September 27, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriskowal kriskowal kriskowal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @kriskowal