fix governance pack

[turadg]

Description

The @agoric/governance publishing in dev-canary started failing in https://github.com/Agoric/agoric-sdk/actions/runs/3431814886/jobs/5720455594 with many TS errors.

In master there are 11 left:

errors in master

> @agoric/governance@0.9.1 prepack
> tsc --build jsconfig.build.json

../zoe/src/zoeService/types.js:294:20 - error TS2304: Cannot find name 'BundleID'.

294  * @property {(id: BundleID) => ERef<BundleCap>} waitForBundleCap
                       ~~~~~~~~

../zoe/src/zoeService/types.js:294:38 - error TS2304: Cannot find name 'BundleCap'.

294  * @property {(id: BundleID) => ERef<BundleCap>} waitForBundleCap
                                         ~~~~~~~~~

../zoe/src/zoeService/types.js:295:20 - error TS2304: Cannot find name 'BundleID'.

295  * @property {(id: BundleID) => ERef<BundleCap>} getBundleCap
                       ~~~~~~~~

../zoe/src/zoeService/types.js:295:38 - error TS2304: Cannot find name 'BundleCap'.

295  * @property {(id: BundleID) => ERef<BundleCap>} getBundleCap
                                         ~~~~~~~~~

../zoe/src/zoeService/types.js:296:38 - error TS2304: Cannot find name 'BundleCap'.

296  * @property {(name: string) => ERef<BundleCap>} getNamedBundleCap
                                         ~~~~~~~~~

../zoe/src/zoeService/types.js:297:27 - error TS2552: Cannot find name 'BundleCap'. Did you mean 'bundleCap'?

297  * @property {(bundleCap: BundleCap, options?: Record<string, any>) => ERef<RootAndAdminNode>} createVat
                              ~~~~~~~~~

  ../zoe/src/zoeService/types.js:297:16
    297  * @property {(bundleCap: BundleCap, options?: Record<string, any>) => ERef<RootAndAdminNode>} createVat
                       ~~~~~~~~~~~~~~~~~~~~
    'bundleCap' is declared here.

../zoe/src/zoeService/types.js:301:26 - error TS2304: Cannot find name 'BundleCap'.

301  * @typedef {{bundleCap: BundleCap } | {name: string} | {id: BundleID}} ZCFSpec
                             ~~~~~~~~~

../zoe/src/zoeService/types.js:301:62 - error TS2304: Cannot find name 'BundleID'.

301  * @typedef {{bundleCap: BundleCap } | {name: string} | {id: BundleID}} ZCFSpec
                                                                 ~~~~~~~~

../SwingSet/src/lib/storageAPI.js:133:12 - error TS2304: Cannot find name 'KVStore'.

133  * @param {KVStore} kvStore  The StorageAPI object to wrap
               ~~~~~~~

../SwingSet/src/lib/storageAPI.js:142:24 - error TS2304: Cannot find name 'KVStore'.

142  * @returns {{kvStore: KVStore, commit: () => void, abort: () => void}}
                           ~~~~~~~

../SwingSet/src/lib/message.js:15:33 - error TS2304: Cannot find name 'Message'.

15  * @returns {asserts message is Message}
                                   ~~~~~~~


Found 11 errors.

This resolves those by making some explicit type imports in in SwingSet and Zoe instead of relying on ambients.

Security Considerations

Documentation Considerations

Testing Considerations

Ran npm pack in governance locally.