Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate API Doc (reference) with agoric-sdk api-doc #319

Closed
4 tasks
katelynsills opened this issue Sep 25, 2020 · 3 comments
Closed
4 tasks

integrate API Doc (reference) with agoric-sdk api-doc #319

katelynsills opened this issue Sep 25, 2020 · 3 comments
Assignees
Labels
api-docs issues that generated api-docs should address documentation Tooling Has to do with documentation tools and process

Comments

@katelynsills
Copy link
Contributor

katelynsills commented Sep 25, 2020

a possible plan:

earlier:

It appears that our types in agoric-sdk will cause jsDoc to error. For instance:

ERROR: Unable to parse a tag's type expression for source file /Users/katesills/code/agoric-sdk/packages/zoe/src/contractFacet/types.js in line 4 with tag title "property" and text "{(keyword: Keyword) => void} assertUniqueKeyword - check
whether a keyword is valid and unique and could be added in
`saveIssuer`": Invalid type expression "(keyword: Keyword) => void": Expected "$", "'", ".", "0", "@", "\"", "\\", "_", "break", "case", "catch", "class", "const", "continue", "debugger", "default", "delete", "do", "else", "enum", "export", "extends", "finally", "for", "function", "if", "implements", "import", "in", "instanceof", "interface", "let", "new", "package", "private", "protected", "public", "return", "static", "super", "switch", "this", "throw", "try", "typeof", "var", "void", "while", "with", "yield", Unicode letter number, Unicode lowercase letter, Unicode modifier letter, Unicode other letter, Unicode titlecase letter, Unicode uppercase letter, or [1-9] but " " found.

TypeDoc does not error and seems the most promising. It produces documentation like this:

Screen Shot 2020-09-25 at 3 47 41 PM

It seems like it will take some configuration changes to make it usable. Then there is the challenge of reconciling it with our current site.

@katelynsills katelynsills self-assigned this Sep 25, 2020
@tyg tyg added the Tooling Has to do with documentation tools and process label Feb 1, 2021
@Tyrosine22 Tyrosine22 self-assigned this Jan 10, 2023
@dckc
Copy link
Member

dckc commented Feb 2, 2024

JSDoc errors were addressed a of:

So we've done the exploration. I'm re-scoping this to integrate the docs site with the generated api-doc.

@dckc dckc changed the title Explore Automatic API Doc creation using agoric-sdk as the source integrate API Doc with agoric-sdk api-doc Feb 2, 2024
@dckc dckc changed the title integrate API Doc with agoric-sdk api-doc integrate API Doc (reference) with agoric-sdk api-doc Feb 12, 2024
@dckc dckc added the api-docs issues that generated api-docs should address label Mar 19, 2024
@sufyaankhan
Copy link

sufyaankhan commented Apr 1, 2024

Dupe of #927

@dckc
Copy link
Member

dckc commented Apr 3, 2024

fixed in #1038

@dckc dckc closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-docs issues that generated api-docs should address documentation Tooling Has to do with documentation tools and process
Projects
None yet
Development

No branches or pull requests

7 participants