Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout repository and select patch branch #3

Closed
Tracked by #2
AkMo3 opened this issue May 21, 2023 · 3 comments
Closed
Tracked by #2

Checkout repository and select patch branch #3

AkMo3 opened this issue May 21, 2023 · 3 comments
Assignees
Milestone

Comments

@AkMo3
Copy link
Owner

AkMo3 commented May 21, 2023

Purpose:

  • When a milestone is closed, this should indicate that the release should be made for that milestone.
  • Closing a milestone is a trigger for the GH actions release process.

Timeline:

  • Milestone gets closed
  • GH actions starts
  • There is some gating that blocks the GH action from finishing ('permanent' actions/results -- npm release), and someone needs to hit a button or something to confirm first

Details:

This task consists of action to checkout the appropriate branch for a patch release, which can be done using two ways:

  1. Manually giving input using workflow_dispatch
  2. On completion of a milestone, get the label of milestone which specifies the release to which the patch be applied.
  3. Documentation: The trigger needs to be obvious to everyone.

Inputs:

  • Branch
  • Type of release that you're making: patch / feature -- apply to most/all of the scripts/actions

Testing: How do we confirm that this is working.

  • Example GH action
  • Test on closing of milestone in this repo -- scope this to a particular milestone name (testissue3)
  • Or: disable the test gh action when done
  • Manually confirm
@maxkfranz maxkfranz changed the title Task #2: Checkout repository and select patch branch Checkout repository and select patch branch May 25, 2023
@maxkfranz maxkfranz added this to the M1 milestone May 25, 2023
@maxkfranz
Copy link
Collaborator

maxkfranz commented Jun 1, 2023

For future (maybe): Mike's suggestion re. the automatic type of release (patch versus feature) => automatically inferred by the version number in future

@AkMo3
Copy link
Owner Author

AkMo3 commented Jun 1, 2023

Move from composite actions to bash scripts

@AkMo3
Copy link
Owner Author

AkMo3 commented Jun 4, 2023

Updated patch-release-test.yml to use bash script to get patch branch defined in parse-branch-from-milestone.sh.

Setting the output to environment variable with label PATCH_BRANCH

@AkMo3 AkMo3 closed this as completed Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants