Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing design tokens #137

Closed
5 tasks done
leeejune opened this issue Dec 6, 2023 · 2 comments · Fixed by #138
Closed
5 tasks done

Add missing design tokens #137

leeejune opened this issue Dec 6, 2023 · 2 comments · Fixed by #138
Assignees
@jordanjones243
Labels
design tokens Type: Design New or related Design work Type: Feature New Feature

Comments

@leeejune
Copy link
Contributor

leeejune commented Dec 6, 2023 •
edited by blackfalcon

Is your feature request related to a problem? Please describe.

There are a few design tokens that were deprecated but are still in use/are missing:

Alias

ds-color-ui-default-inverse: ds-color-brand-breeze-300
ds-color-ui-hover-inverse: ds-color-brand-breeze-200

UI active tokens

  • ds-color-ui-active-inverse: ds-color-brand-breeze-200

UI background

  • ds-color-ui-bkg-default-default: #00000008
  • ds-color-ui-bkg-default-inverse: #FFFFFF08
  • ds-color-ui-bkg-hover-inverse: #FFFFFF0F

border

  • ds-color-border-active-inverse: ds-color-brand-breeze-300

Describe the solution you'd like

Add the listed design tokens to the library.

Describe alternatives you've considered

No response

Additional context

This will resolve: AlaskaAirlines/auro-button#228 (comment)

Exit Criteria

Validate that the new tokens show up on the doc site.
@leeejune leeejune added Type: Feature New Feature Type: Design New or related Design work design tokens not-reviewed Issue has not been reviewed by Auro team members labels Dec 6, 2023
This was referenced Dec 6, 2023
Merged
Closed
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Dec 8, 2023
@jordanjones243 jordanjones243 self-assigned this Dec 11, 2023
@jordanjones243
Copy link
Contributor

ds-color-ui-default-inverse and ds-color-ui-hover-inverse already exist in our design tokens

jordanjones243 added a commit that referenced this issue Dec 11, 2023
@jordanjones243
feat(tokens): add new design tokens #137
a3d89c7
@jordanjones243 jordanjones243 mentioned this issue Dec 11, 2023
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Dec 11, 2023 that will close this issue
Add new design tokens #138
Merged
6 tasks
@leeejune
Copy link
Contributor Author

leeejune commented Dec 12, 2023 •
edited

ds-color-ui-default-inverse and ds-color-ui-hover-inverse already exist in our design tokens
@jordanjones243 I was referring to the "color palette" page on the doc site and it seems like it's not fully up to date with the "design tokens" page. If it already exists, no need to add it! I'll edit the issue.

Screenshot 2023-12-12 at 12 17 45 PM

jordanjones243 added a commit that referenced this issue Dec 12, 2023
@jordanjones243
feat(tokens): add new design tokens #137
f7f71aa
jordanjones243 added a commit that referenced this issue Dec 12, 2023
@jordanjones243
feat(tokens): add new design tokens #137
dd11027
jordanjones243 added a commit that referenced this issue Dec 28, 2023
@jordanjones243
feat(tokens): add requested design tokens #137
3690b09
jordanjones243 added a commit that referenced this issue Dec 29, 2023
@jordanjones243
feat(tokens): add requested design tokens #137
8c832d3
blackfalcon pushed a commit that referenced this issue Dec 29, 2023
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
2b74f57 
# [4.3.0](v4.2.0...v4.3.0) (2023-12-29)

### Features

* **tokens:** add requested design tokens [#137](#137) ([8c832d3](8c832d3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
design tokens Type: Design New or related Design work Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new design tokens AlaskaAirlines/AuroDesignTokens
3 participants
@jordanjones243 @leeejune @Patrick-Daly-AA