Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-pane: Error When Importing from CDN #31

Open
isaiahscheel opened this issue Nov 8, 2022 · 3 comments
Open

auro-pane: Error When Importing from CDN #31

isaiahscheel opened this issue Nov 8, 2022 · 3 comments

Comments

@isaiahscheel
Copy link

Describe the bug

A clear and concise description of what the bug is.

  • Shopping team has started to pull in auro compontents from CDN like:
<script type="module" src="https://unpkg.com/@alaskaairux/auro-pane@1.2.1/dist/auro-pane__bundled.js"></script>
  • When using it like this we are getting the following error:

image

To Reproduce

Expected behavior

A clear and concise description of what you expected to happen.

  • Not have errors

Screenshots

If applicable, add screenshots to help explain your problem.

  • See above

Additional context

Add any other context about the problem here.

  • Reach out to me with any Qs!
  • Mostly making a report to make sure it is documented and if shopping cannot fix ourselves
@isaiahscheel isaiahscheel added the Type: Bug Bug or Bug fixes label Nov 8, 2022
@isaiahscheel
Copy link
Author

I think we fixed this on our side by not bringing in the auro pane from CDN like specified above so the error isn't happening. Apologies for the bug report that might not actually be a bug

@blackfalcon blackfalcon removed their assignment Nov 14, 2022
@blackfalcon
Copy link
Member

Currently, auro-pane is NOT being used from the CDN in the Auro Docsite, so there may well be an issue with the pre-packaged version of the element. This issue will be reviewed and addressed as needed as priorities allow.

@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Nov 23, 2022
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Jan 24, 2023
@blackfalcon
Copy link
Member

I am not sure we need to address this bug directly. There is more value to be gained by updating this repo to the latest version of tooling which I assume would address the actual bug.

@blackfalcon blackfalcon added this to the auro-pane v2.0-rc milestone Feb 23, 2023
@jason-capsule42 jason-capsule42 removed the Type: Bug Bug or Bug fixes label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants