This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Fix #170 by not using ANSI DSR on every key press #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the ANSI DSR escape code on every key press, only do it once at the beginning of reading input, and keep track of cursor location ourselves.
|
Awesome! Thanks for the contribution 🎉 I'm going to give this a swing on my windows machine to make sure everything works there. Will let you know how that goes |
|
Alright cool this seems to be working just fine. Sorry for the wait! |
AlecAivazis
approved these changes
Jan 23, 2019
|
No worries, thank you for looking! |
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Jan 29, 2019
…constraint e1f28c2 moved to revision from a version to being in [1]. But a new release [2] includes the change from [1]. So switching back to version for dep constraint. [1] AlecAivazis/survey#174
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Jan 29, 2019
…constraint e1f28c2 moved to revision from a version to being in [1]. But a new release [2] includes the change from [1]. So switching back to version for dep constraint. [1] AlecAivazis/survey#174 [2] https://github.com/AlecAivazis/survey/releases/tag/v1.8.1
siredmar
pushed a commit
to siredmar/survey
that referenced
this pull request
Feb 20, 2020
…azis#174) Instead of using the ANSI DSR escape code on every key press, only do it once at the beginning of reading input, and keep track of cursor location ourselves.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the ANSI DSR escape code on every key press, only do it
once at the beginning of reading input, and keep track of cursor
location ourselves.
In the examples below pasting some text, the speed improvement is dramatic.
Before:
After: