Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor(github.com/AlecAivazis/survey): switch back to version(1.8.1) constraint #1142

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

abhinavdahiya
Copy link
Contributor

e1f28c2 moved to revision from a version to being in [1].
But a new release [2] includes the change from [1].

So switching back to version for dep constraint.

[1] AlecAivazis/survey#174
[2] https://github.com/AlecAivazis/survey/releases/tag/v1.8.1

…constraint

e1f28c2 moved to revision from a version to being in [1].
But a new release [2] includes the change from [1].

So switching back to version for dep constraint.

[1] AlecAivazis/survey#174
[2] https://github.com/AlecAivazis/survey/releases/tag/v1.8.1
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2019
@crawford
Copy link
Contributor

Diff between the previous version and this: AlecAivazis/survey@49e2fbe...v1.8.1

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor Author

Diff between the previous version and this: AlecAivazis/survey@49e2fbe...v1.8.1

Thanks for that! :)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1fc7ccd into openshift:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants