Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires async keyword before finalize statement. #2088

Merged
merged 6 commits into from
Sep 21, 2022
Merged

Requires async keyword before finalize statement. #2088

merged 6 commits into from
Sep 21, 2022

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Sep 21, 2022 •
edited
Loading

^

Ready for review, but do not merge until this is approved.

acoglio
acoglio approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also made a note to add that to the ABNF grammar.

@d0cd d0cd mentioned this pull request Sep 21, 2022
Merged
@collinc97 collinc97 merged commit 9b9c494 into testnet3 Sep 21, 2022
@collinc97 collinc97 deleted the feat/async-on-finalize-statement branch September 21, 2022 21:41
acoglio added a commit that referenced this pull request Sep 23, 2022
@acoglio
[ABNF] Add async keyword.
ef83c6f 
Matches #2088.
@acoglio acoglio mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinc97 collinc97 collinc97 approved these changes

@acoglio acoglio acoglio approved these changes

@bendyarm bendyarm Awaiting requested review from bendyarm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d0cd @acoglio @collinc97