Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Updated analysis: Re-calculate coding TMB with Lancet WXS BED file update #440

Closed
cansavvy opened this issue Jan 15, 2020 · 7 comments
Closed
Assignees
Labels
snv Related to or requires SNV data updated analysis

Comments

@cansavvy
Copy link
Collaborator

cansavvy commented Jan 15, 2020

What analysis module should be updated and why?

snv-callers where coding TMB is calculated

Why should the module be updated?

Because the current WXS BED file is not accurate for the Lancet data and will be updated. It was a 100bp that needed to be run and a 300bp window was run.

What changes need to be made? Please provide enough detail for another participant to make the update.

  • If the Lancet file is updated then the whole pipeline will need to be re-ran with the updated data
  • Need to reconfigure the coding WXS TMB to include the new BED file.

What input data should be used? Which data were used in the version being updated?

I think this update will be in v13.

When do you expect the revised analysis will be completed?

We can have in revised for v14

Who will complete the updated analysis?

@cansavvy

@cansavvy cansavvy added updated analysis blocked Blocked by factors external to this project snv Related to or requires SNV data labels Jan 15, 2020
@jharenza
Copy link
Collaborator

correct, will release this bed with #373

@jaclyn-taroni
Copy link
Member

@jharenza there is a little confusion on our end. The methods section of the manuscript reported that for WXS samples, Lancet was run with a 100 bp padded bed file. It was in fact run with a 300 bp padded file. You are planning on releasing the WXS BED with 300 bp padding now, but there will be no underlying changes to the Lancet data (e.g., you will not be rerunning it with 100 bp). Is that correct?

@jharenza
Copy link
Collaborator

Correct. I think the intersect for WXS should stay similar anyway, since there is an intersect with CDS regions.

@jaclyn-taroni
Copy link
Member

#444 (comment)

@jaclyn-taroni jaclyn-taroni removed the blocked Blocked by factors external to this project label Jan 18, 2020
@jaclyn-taroni
Copy link
Member

This was blocked by the v13 release, which went out yesterday in #444 so I am removing the blocked label.

@cansavvy
Copy link
Collaborator Author

This issue has been addressed. The results have been uploaded to S3.
Changes to S3 files:

@jaclyn-taroni
Copy link
Member

Closed via #459.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
snv Related to or requires SNV data updated analysis
Projects
None yet
Development

No branches or pull requests

3 participants