-
Notifications
You must be signed in to change notification settings - Fork 67
Updated analysis: What is the right disease label/grouping to use for interaction plots? #917
Comments
Regarding this question @jaclyn-taroni , we have since created some logic to make a
|
Adding this to the histology file for v20 for this purpose sounds good 👍🏻 |
Just wanted to add the original ticket for assigning cancer_group here for reference. |
Should I close this since |
sure! we also probably only want to plot N>=5 cancer groups - display group will stay in some figures, but we will also need cancer group as well for others |
What analysis module should be updated and why?
In #915, the interaction plots module is being updated to use
broad_histology
becauseintegrated_diagnosis
is less complete in v18 andharmonized_diagnosis
has many different values. I don't think this is quite right.The question is: What is the right disease label/grouping to use for the interaction plots module for the co-occurrence information to be useful? I suspect that the "right" grouping might come from dropping
harmonized_diagnosis
values with small sample sizes and combining others. If that's the case, we may need to rethink how that module is structured, e.g., by adding a notebook that explains combining labels, etc. if it is not a more general step to be used in other modules.What input data should be used? Which data were used in the version being updated?
SNV data and
broad_histology
labels from v18 are being used #915.The text was updated successfully, but these errors were encountered: