Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloaders tests #3231

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Fix downloaders tests #3231

merged 4 commits into from
Apr 6, 2023

Conversation

arkid15r
Copy link
Contributor

@arkid15r arkid15r commented Mar 6, 2023

Purpose/Implementation Notes

Fix tests for downloader_no_op_tests:

  • Update requirements.
  • Fix aspera downloader.
  • Migrate to new sra data source.
  • Update docker image.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@arkid15r
Fix downloaders tests:
e0c5d8d 
  - Update requirements.
  - Fix aspera downloader.
  - Migrate to new sra data source.
  - Update docker image.
@arkid15r arkid15r mentioned this pull request Mar 10, 2023
Closed
@arkid15r arkid15r linked an issue Mar 16, 2023 that may be closed by this pull request
Fix downloader_no_op_tests MissingSchema exception #3214
Closed
@arkid15r arkid15r mentioned this pull request Mar 16, 2023
Closed
davidsmejia
davidsmejia requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one documentation request.

workers/keys/asperaweb_id_dsa.openssh Outdated Show resolved Hide resolved
davidsmejia
davidsmejia reviewed Apr 6, 2023
View reviewed changes
workers/keys/README.md Outdated Show resolved Hide resolved
davidsmejia
davidsmejia approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐼

@arkid15r @davidsmejia
Update workers/keys/README.md
04e3919 
Co-authored-by: David <davidsmejia@gmail.com>
@arkid15r arkid15r merged commit f84fa48 into feature/automatic-accessions Apr 6, 2023
@arkid15r arkid15r deleted the ark/fix-downloaders-tests branch April 6, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees

@davidsmejia davidsmejia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix downloader_no_op_tests MissingSchema exception
2 participants
@arkid15r @davidsmejia