Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix common, foreman tests #3254

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Fix common, foreman tests #3254

merged 2 commits into from
Apr 14, 2023

Conversation

arkid15r
Copy link
Contributor

@arkid15r arkid15r commented Apr 11, 2023 •
edited
Loading

Purpose/Implementation Notes

Migrate common/migrations image to dr_base.
Move foreman tests to tests directory.
Add separate settings file (tests/settings.py).
Refactor import according to the new structure.

Methods

NA

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

NA

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

NA

@arkid15r
Fix common/oreman tests.
a34004e 
Migrate common/migrations image to `dr_base`.

Move foreman tests to tests directory.
Add separate settings file (tests/settings.py).
Refactor import according to the new structure.
davidsmejia
davidsmejia requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor suggestions for improvement

foreman/data_refinery_foreman/foreman/management/commands/update_experiment_metadata.py Show resolved Hide resolved
foreman/data_refinery_foreman/surveyor/array_express.py Outdated Show resolved Hide resolved
foreman/tests/foreman/management/commands/test_update_experiment_metadata.py Outdated Show resolved Hide resolved
davidsmejia
davidsmejia approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r merged commit ec952d9 into feature/automatic-accessions Apr 14, 2023
@arkid15r arkid15r deleted the ark/fix-tests branch April 14, 2023 15:18
@arkid15r arkid15r linked an issue Apr 18, 2023 that may be closed by this pull request
Fix "rpy2 in API mode cannot be built..." error #3251
Closed
@arkid15r arkid15r mentioned this pull request Apr 18, 2023
Closed
@arkid15r arkid15r linked an issue Apr 18, 2023 that may be closed by this pull request
Fix test_foreman failing job #3203
Closed
@arkid15r arkid15r mentioned this pull request Apr 18, 2023
Closed
@arkid15r arkid15r linked an issue Apr 18, 2023 that may be closed by this pull request
Fix failing test_foreman job #3080
Closed
@arkid15r arkid15r mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsmejia davidsmejia davidsmejia approved these changes

Assignees

@davidsmejia davidsmejia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "rpy2 in API mode cannot be built..." error Fix test_foreman failing job Fix failing test_foreman job
2 participants
@arkid15r @davidsmejia