New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
theme docs #25
theme docs #25
Conversation
Generally this looks pretty good to me and I'm good with the overall look. I was able to test it locally to following the instructions in the readme and everything works as it should. The only thing that jumps out at me here is that the title of the docs is kind of weird still. Is there a way to change that so it just says like |
I added a blurb and changed the name of the document. Also updated the TOC to not be quite so default in appearance. |
updated screen shots to reflect recent changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The only thing I want comment on is the link to the page source in the upper right. I don't see any reason to include that as is, but I note that http://docs.refine.bio/ links back to github there, which seems to make a bit more sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM also! But before we merge this, I'll just ask you to add a .gitignore
that will help prevent us from doing silly things down the line & have unstaged files lists look more reasonable:
# ignore virtualenv & local build
env
docs/_build
Co-authored-by: Ally Hawkins <54039191+allyhawkins@users.noreply.github.com>
Can it say ScPCA Portal Docs? |
index.rst
toindex.md