-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan new scpca-nf release with CITE-seq post-processing #353
Comments
@sjspielman, you probably want to use the release checklist template to track this: https://github.com/AlexsLemonade/scpca-nf/issues/new?assignees=&labels=release&projects=&template=release-checklist.md&title=Prepare+for+scpca-nf+release+vX.X.X |
I'm not sure we should try to pick out changes at this point. There is enough interleaved that I think it may simply be better to include all updates to this point, unless there are specific changes we think should not go in. |
If we do that it includes the cell type workflow and integration workflows. Right now they are separate so don't get run by the main workflow, but just noting that they do exist so maybe we don't want to include those? |
Maybe not ideal, but I think I would rather have them in Another option (which I don't know how I feel about), is branching off "development" with cell typing and integration as their own branches, then removing those workflows from development. I think this is likely to end up with some pretty error-prone merges too though (unless we remove them first, then branch and revert the removal commits in the new branches). No great options here, I guess. |
Argh, the template of course... Let's continue to chat about plans for release here re-"which commits/features" and I'll open a better issue from template for the release itself. |
I'm okay with including them and avoiding errors and issues with keeping things in sync. I just wanted to make sure everyone knew that those will also be present if we merge in all changes. |
I'm also good either way, so this is helpful since my original plan was to not include cell-typing or integration! Since we'd call these features experimental for now, I imagine they would get loosely documented in release notes (my note to self..), but I wonder if there's anything else we'd want to add to internal or external instructions just reminding folks that they are experimental. That said, I don't think this is critical; any other opinions? |
Noting also we have updated approaches for references which would get included in a new release containing everything in |
These updates have been accounted for in the docs, so we are good to release those.
I think including them as experimental still in the release notes is good. |
To get a sense of whether there are any sneaky changes that releasing all
So, the question is, do these changes raise to the level of needing to re-process all projects with this new release? If so, would it make more sense to cherry-pick such that only CITE-seq projects would be meaningfully affected by the re-release? Would a whole ScPCA refresh make sense at this stage anyways? I'm attaching here the two QC reports for SCE version as well as a super quick notebook I compared SCEs in. |
Thanks for doing this comparison. It seems quite likely that most of the changes are to do with updated containers. Notably the As we do record the pipeline version in the outputs (though apparently not in the QC report), and these changes appear quite minor (I expect the changes in HVG are for genes at the lower end of the vector, which you can confirm) I am not concerned that we need to reprocess everything at this stage. As we add functionality (cell typing), everything will get rerun through at least the later part of the pipelin (not including |
Yep -
|
Going to close out this discussion since we have a plan now moving forward. See #354 for the actual release issue. |
As part of closing out the #291 Epic, we'll want to actually cut the new
scpca-nf
release with cite-seq post-processing. This will almost certainly involve only including selected commits fromdevelopment
into the release.The text was updated successfully, but these errors were encountered: