[ACS-3887] Rule set listing, including linked & inherited rules #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
requested review from
MichalKinas,
nikita-web-ua,
jatin2008,
rbahirsheth,
AleksanderSklorz and
arohilaGL
TomikaArome
changed the title
MichalKinas
requested changes
Nov 16, 2022
| FolderRuleSetsService, | ||
| FolderRulesService, | ||
| { provide: Store, useValue: { dispatch: () => {} } }, | ||
| // { provide: FolderRulesService, useValue: folderRulesServiceSpy }, |
There was a problem hiding this comment.
Unremoved commented code
| let contentApiService: ContentApiService; | ||
|
|
||
| let callApiSpy: jasmine.Spy; | ||
| // let loadRulesSpy: jasmine.Spy; |
| if (nodeId) { | ||
| return this.contentApi.getNode(nodeId).pipe( | ||
| catchError((error) => { | ||
| if (error.status === 404) { |
There was a problem hiding this comment.
Do we have some file with constants that we use across whole app? If not it may be worth to consider creating one for example for storing HTTP status codes as constants instead of using just raw numbers
There was a problem hiding this comment.
As far as I know, no, but HTTP codes are pretty well known so perhaps it's not as crucial here.
There was a problem hiding this comment.
Yeah don't worry this is just an idea for the future
added 9 commits
November 16, 2022 15:02
TomikaArome
force-pushed
the
feature/dev-thunter-ACS-3887-linked-inherited-rule-sets-listing
branch
from
77fed3d
to
640d03f
Compare
MichalKinas
approved these changes
Nov 16, 2022
TomikaArome
deleted the
feature/dev-thunter-ACS-3887-linked-inherited-rule-sets-listing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-3887
What is the new behaviour?
All rule sets for a folder are listed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: