[ACA-4627] Folder Rules - clicking on Manage Rules button does not fire the correct requests to the backend for inherited rules #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomikaArome
approved these changes
Nov 30, 2022
KikoUK
approved these changes
Nov 30, 2022
|
LGTM. Are there any unit tests around this area already? |
DenysVuika
reviewed
Nov 30, 2022
| @@ -186,7 +186,7 @@ export class FolderRuleSetsService { | |||
| } | |||
| return combineLatest( | |||
| this.currentFolder?.id === entry.owningFolder ? of(this.currentFolder) : this.getNodeInfo(entry.owningFolder || ''), | |||
| this.folderRulesService.getRules(entry.owningFolder || '', entry.id) | |||
| this.folderRulesService.getRules(this.currentFolder.id || '', entry.id) | |||
There was a problem hiding this comment.
can we have some sort of unit test to avoid issues in the future?
DenysVuika
approved these changes
Nov 30, 2022
DenysVuika
deleted the
fix/dev-mmaliarchuk-ACA-4627-folder-rules-clicking-on-manage-rules-button-does-not-fire-the-correct-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4627
What is the new behaviour?
GET Rules request for inherited rules is sent to the Child folder instead of the Parent folder.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: