Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-4627] Folder Rules - clicking on Manage Rules button does not fire the correct requests to the backend for inherited rules #2822

Merged
merged 2 commits into from
Nov 30, 2022
Merged

[ACA-4627] Folder Rules - clicking on Manage Rules button does not fire the correct requests to the backend for inherited rules #2822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be260c
ACA-4627 - changed from parent id to the current folder id
nikita-web-ua Nov 30, 2022
e1a58aa
ACA-4627 - unit test
nikita-web-ua Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/aca-folder-rules/src/lib/services/folder-rule-sets.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export class FolderRuleSetsService {
}
return combineLatest(
this.currentFolder?.id === entry.owningFolder ? of(this.currentFolder) : this.getNodeInfo(entry.owningFolder || ''),
this.folderRulesService.getRules(entry.owningFolder || '', entry.id)
this.folderRulesService.getRules(this.currentFolder.id || '', entry.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have some sort of unit test to avoid issues in the future?

).pipe(
map(([owningFolderNodeInfo, getRulesRes]) => ({
id: entry.id,
Expand Down