[AAE-11496] Build and publish aca-about and aca-settings #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
changed the title
BSekula
force-pushed
the
dev-bsekula-AAE-11496-build-aca-settings-aca-about
branch
from
a51615c
to
5f6ffc4
Compare
BSekula
commented
Jan 30, 2023
| import { DEV_MODE_TOKEN } from './dev-mode.tokens'; | ||
| import pkg from 'package.json'; |
There was a problem hiding this comment.
Cannot build library if file is imported from outside of the library root folder, therefore provided it using service
BSekula
force-pushed
the
dev-bsekula-AAE-11496-build-aca-settings-aca-about
branch
from
5f5d725
to
ac03f16
Compare
| @@ -29,12 +29,13 @@ import { AcaAboutModule } from '@alfresco/aca-about'; | |||
| import { AcaSettingsModule } from '@alfresco/aca-settings'; | |||
| import { AcaFolderRulesModule } from '@alfresco/aca-folder-rules'; | |||
| import { environment } from '../environments/environment'; | |||
| import packageJson from 'package.json'; | |||
|
|
|||
| @NgModule({ | |||
| imports: [ | |||
| AosExtensionModule, | |||
There was a problem hiding this comment.
Not sure about this. Does it mean that content-ee will use the package of aca about?
There was a problem hiding this comment.
this module is going to be overridden by content-ee with its own package.json file
mauriziovitale
approved these changes
Jan 30, 2023
BSekula
deleted the
dev-bsekula-AAE-11496-build-aca-settings-aca-about
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: