-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAE-11496] Build and publish aca-about and aca-settings #2942
[AAE-11496] Build and publish aca-about and aca-settings #2942
Conversation
a51615c
to
5f6ffc4
Compare
import { DEV_MODE_TOKEN } from './dev-mode.tokens'; | ||
import pkg from 'package.json'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot build library if file is imported from outside of the library root folder, therefore provided it using service
5f5d725
to
ac03f16
Compare
@@ -29,12 +29,13 @@ import { AcaAboutModule } from '@alfresco/aca-about'; | |||
import { AcaSettingsModule } from '@alfresco/aca-settings'; | |||
import { AcaFolderRulesModule } from '@alfresco/aca-folder-rules'; | |||
import { environment } from '../environments/environment'; | |||
import packageJson from 'package.json'; | |||
|
|||
@NgModule({ | |||
imports: [ | |||
AosExtensionModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this. Does it mean that content-ee will use the package of aca about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this module is going to be overridden by content-ee
with its own package.json
file
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: