Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-11496] Publish aca-viewer and aca-preview #2945

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

BSekula
Copy link
Contributor

@BSekula BSekula commented Jan 30, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
In order to publish aca-content with lazy loaded viewer and preview, we need to extract these libs to different libraries

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@@ -130,3 +130,23 @@ jobs:
cache: 'npm'
- run: npm ci
- run: npm test aca-folder-rules -- --browsers=ChromeHeadless --watch=false $TEST_OPTS

test-aca-preview:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only preview, the viewer does not have tests

@BSekula BSekula force-pushed the dev-bsekula-AAE-11496-publish-viewer-and-preview branch from 4979ae4 to f0159eb Compare January 30, 2023 15:42
@BSekula BSekula force-pushed the dev-bsekula-AAE-11496-publish-viewer-and-preview branch from f0159eb to e9d4b9d Compare January 31, 2023 13:33
@BSekula BSekula merged commit c8e8619 into develop Jan 31, 2023
@BSekula BSekula deleted the dev-bsekula-AAE-11496-publish-viewer-and-preview branch January 31, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants