Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILEAPPS-1707] Custom URL schema new issues from Frontend - dark squared shade for Open in App button, Banner is disappearing for the PDF files in ios and android #3018

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

jatin2008
Copy link
Contributor

@jatin2008 jatin2008 commented Feb 27, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

  1. The dark squared shade is showing on the backside “Open in app” text when the user clicks on the URL.
    2.The Banner is disappearing for the PDF files, so adding the PDF URLs

What is the new behaviour?

  1. The dark squared shade will now show on the backside “Open in app” text when the user clicks on the URL.
  2. The banner will not disappear for the PDF files when shown in preview mode for android as well as for ios.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@nikita-web-ua
Copy link
Contributor

Also, please pay attention on commit message guidelines. Remember to put the issue id in your commit message

@jatin2008 jatin2008 merged commit cf4e5fe into develop Feb 28, 2023
@jatin2008 jatin2008 deleted the dev-jatin-mobileapps-1707 branch February 28, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants