[ACS-4277] Changed whitespace to normal in order to make longer notifications messages visible #8238
Conversation
arohilaGL
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
Typo in PR title + missing space after square bracket |
lib/core/src/lib/notifications/components/notification-history.component.scss
Outdated
Show resolved
Hide resolved
|
you have multiple typos in the PR title, |
|
@arohilaGL please put the spaces after jira ticket, and pay attention to the comments |
arohilaGL
force-pushed
the
dev-arohila-ACS-4277_2
branch
from
bbac4eb
to
414f40b
Compare
arohilaGL
changed the title
lib/core/src/lib/notifications/components/notification-history.component.scss
Show resolved
Hide resolved
| @@ -69,3 +69,8 @@ | |||
| padding: 0; | |||
| } | |||
| } | |||
|
|
|||
| .mat-list-base .mat-list-item.adf-notification-history-menu-no-message .mat-line, | |||
There was a problem hiding this comment.
Small comment but that can be a bit shorter:
.mat-list-base .mat-list-item {
&.adf-notification-history-menu-no-message .mat-line, .adf-notification-history-menu-message.mat-line {
white-space: normal;
}
}Thanks that you don't need to repeat .mat-list-base .mat-list-item twice.
There was a problem hiding this comment.
the path for the css is unreasonably long, just create a dedicated class for the mat-line in the Notification component, and style it directly, i.e.
.adf-notification-message-line { white-space: normal; }
|
I don't think we should... the PR is changing the general mat-list-item. Therefore all the apps will be impacted. Please work with alfresco BDU to make sure there won't be any side effects. |
| @@ -69,3 +69,8 @@ | |||
| padding: 0; | |||
| } | |||
| } | |||
|
|
|||
| .mat-list-base .mat-list-item.adf-notification-history-menu-no-message .mat-line, | |||
There was a problem hiding this comment.
the path for the css is unreasonably long, just create a dedicated class for the mat-line in the Notification component, and style it directly, i.e.
.adf-notification-message-line { white-space: normal; }
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: partially-approved
labels
…essage visible.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Notification messages get truncated.
What is the new behaviour?
We don't want to limit the visibility of texts in order to make it convenient for accessibility reasons.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: