Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use angular serve for e2e #3085

Merged
merged 11 commits into from
Mar 23, 2023
Merged

use angular serve for e2e #3085

merged 11 commits into from
Mar 23, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Mar 23, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • switch from http-server to standard Angular one
  • workaround for Playwright not waiting till server starts

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika merged commit 73a4c95 into develop Mar 23, 2023
@DenysVuika DenysVuika deleted the e2e-use-angular-server branch March 23, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant