Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #3210

Merged
merged 8 commits into from
May 22, 2023
Merged

code cleanup #3210

merged 8 commits into from
May 22, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented May 20, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • code cleanup based on linting and IntelliJ code inspection
  • remove dead code (unused components)
  • remove unused locales
  • enable no-unused-vars rule and fix errors
  • reduce the use of TranslateModule in tests

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika marked this pull request as ready for review May 20, 2023 17:42
@DenysVuika DenysVuika requested a review from eromano as a code owner May 20, 2023 17:42
@DenysVuika DenysVuika merged commit fd495f6 into develop May 22, 2023
25 checks passed
@DenysVuika DenysVuika deleted the code-cleanup branch May 22, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants