[ACS-6510] playwright List View e2e test #3566
Conversation
…stview-personal-files
| } | ||
|
|
||
| test.describe('Remember sorting', () => { | ||
| interface NodesIds { |
There was a problem hiding this comment.
Why do we need this interface? It can be a simple array of strings instead I think
There was a problem hiding this comment.
removed this interface
| } from '@alfresco/playwright-shared'; | ||
|
|
||
| test.describe('Remember sorting', () => { | ||
| interface NodesIds { |
There was a problem hiding this comment.
removed this interface.
| timeouts | ||
| } from '@alfresco/playwright-shared'; | ||
|
|
||
| test.describe('Remember sorting', () => { |
There was a problem hiding this comment.
Is it possible to run those tests together with ones related to login in the upper file? The setup is quite similar and in this way we can reuse some setup code
There was a problem hiding this comment.
It was getting some failure due to logout related test, now tries some approach and add code in one file.
| parentId: string = '-my-', | ||
| title: string = '', | ||
| description: string = '' | ||
| ): Promise<NodeEntry | null> { |
There was a problem hiding this comment.
If you want to return Promise I wouldn't just return null, you can return rejected promise instead and catch it whenever you use the method
There was a problem hiding this comment.
removed and added reject promise
| majorVersion: boolean = true, | ||
| comment?: string, | ||
| newName?: string | ||
| ): Promise<NodeEntry | null> { |
There was a problem hiding this comment.
removed and added reject promise
| if (isEmpty) { | ||
| return this.emptyListTitle.innerText(); | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
It can be shorter like: return await this.isEmpty() ? this.emptyListTitle.innerText() : '';
There was a problem hiding this comment.
added suggested changes. looks good
| if (isEmpty) { | ||
| return this.emptyListSubtitle.innerText(); | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
Can be shorter as well like in the example above
There was a problem hiding this comment.
added suggested changes. looks good
| if (isEmpty) { | ||
| return this.getChild('adf-custom-empty-content-template').innerText(); | ||
| } | ||
| return ''; |
There was a problem hiding this comment.
added suggested changes. looks good
| @@ -166,4 +166,12 @@ export class PaginationComponent extends BaseComponent { | |||
| async closeMenu(): Promise<void> { | |||
| await this.page.keyboard.press('Escape'); | |||
| } | |||
|
|
|||
| async isRangePresent() { | |||
There was a problem hiding this comment.
Can you specify the return type?
There was a problem hiding this comment.
added return promise type
| return this.range.isVisible(); | ||
| } | ||
|
|
||
| async isMaxItemsPresent() { |
There was a problem hiding this comment.
Can you specify the return type?
There was a problem hiding this comment.
added return promise type
akashrathod28
requested review from
MichalKinas
and removed request for
MichalKinas
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
protractor List View e2e Test
What is the new behaviour? new playwright test
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: https://alfresco.atlassian.net/browse/ACS-6510