Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-3643] Viewer shows both sidebar icons #3852

Merged
merged 3 commits into from
Oct 3, 2018
Merged

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Oct 3, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Enable only right sidebar
Open the viewer

Current behaviour:
It shows two sidebar buttons, the left sidebar is empty.

Expected behavior:
It should be possible to switch off the left sidebar

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-3643

@eromano eromano added this to the 2.6.0 milestone Oct 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #3852 into development will increase coverage by 14.57%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #3852       +/-   ##
================================================
+ Coverage         69.4%   83.97%   +14.57%     
================================================
  Files              760      765        +5     
  Lines            19900    19943       +43     
  Branches          2726     2727        +1     
================================================
+ Hits             13812    16748     +2936     
+ Misses            5426     2373     -3053     
- Partials           662      822      +160
Impacted Files Coverage Δ
lib/core/viewer/components/viewer.component.ts 63.06% <100%> (+36.85%) ⬆️
...ices/task-list/components/attach-form.component.ts 60.71% <0%> (-5.36%) ⬇️
...e/login/components/login-dialog-panel.component.ts 91.66% <0%> (ø) ⬆️
lib/core/testing/core.testing.module.ts 100% <0%> (ø)
lib/core/mock/comment-content-service.mock.ts 100% <0%> (ø)
...b/core/form/components/widgets/core/group.model.ts 100% <0%> (ø)
lib/core/form/models/widget-visibility.model.ts 100% <0%> (ø)
lib/core/test.ts 100% <0%> (ø)
lib/core/utils/momentDateAdapter.ts 50% <0%> (+0.92%) ⬆️
...es/content-node-share/content-node-share.dialog.ts 83.14% <0%> (+1.21%) ⬆️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca80e1...000b4c5. Read the comment docs.

@eromano eromano merged commit 58f61fd into development Oct 3, 2018
@eromano eromano deleted the dev-eromano-ADF-3643 branch February 22, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants