Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5103] FE - Process/task filter - Backporting the components styles to ADF #5614

Merged
merged 11 commits into from May 13, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ADF-5103

What is the new behaviour?

process-services-filters

activiti-filters

process-services-cloud-filters
activiti-cloud-filters

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 6d18a62 to 00c98ef Compare April 17, 2020 14:10
@eromano eromano force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 00c98ef to bb026ed Compare April 17, 2020 20:54
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch 2 times, most recently from 101e6bf to c217614 Compare April 22, 2020 09:35
eromano
eromano previously approved these changes Apr 22, 2020
@mauriziovitale
Copy link
Contributor

should we move this to the next release?

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 7233536 to 3406117 Compare April 27, 2020 17:01
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch 2 times, most recently from 0385997 to 39b6385 Compare May 4, 2020 06:22
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 5352807 to 035286b Compare May 5, 2020 10:21
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 8eeb297 to 3ccf4fe Compare May 5, 2020 19:33
@eromano eromano changed the base branch from development to develop May 6, 2020 10:21
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 3ccf4fe to abdb3e6 Compare May 11, 2020 07:33
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch 3 times, most recently from 0335156 to 8cce0a5 Compare May 11, 2020 19:06
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@27fd18c). Click here to learn what that means.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5614   +/-   ##
==========================================
  Coverage           ?   84.40%           
==========================================
  Files              ?      191           
  Lines              ?     6962           
  Branches           ?      985           
==========================================
  Hits               ?     5876           
  Misses             ?      781           
  Partials           ?      305           
Impacted Files Coverage Δ
...ters/components/process-filters-cloud.component.ts 92.18% <50.00%> (ø)
...ocess-list/components/process-filters.component.ts 81.33% <100.00%> (ø)
...ices-cloud/src/lib/process/process-cloud.module.ts 100.00% <0.00%> (ø)
...ocess-services/src/lib/mock/task/task-list.mock.ts 100.00% <0.00%> (ø)
...services-cloud/src/lib/group/group-cloud.module.ts 100.00% <0.00%> (ø)
...b/process-services/src/lib/task-list/public-api.ts 100.00% <0.00%> (ø)
...ud/src/lib/form/components/form-cloud.component.ts 88.75% <0.00%> (ø)
...ud/src/lib/task/directives/claim-task.directive.ts 94.28% <0.00%> (ø)
...lib/task/task-filters/task-filters-cloud.module.ts 100.00% <0.00%> (ø)
...ss-list/components/process-list-cloud.component.ts 78.64% <0.00%> (ø)
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fd18c...8cce0a5. Read the comment docs.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ADF-5103-backporting-process-task-filters branch from 8cce0a5 to b34d418 Compare May 13, 2020 06:07
@eromano eromano merged commit 2b79439 into develop May 13, 2020
@eromano eromano deleted the dev-siva-ADF-5103-backporting-process-task-filters branch May 13, 2020 13:43
@eromano eromano added this to the 3.9.0 milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants